fix(ci): separate coverage job to prevent cancellation

Coverage was not updating on gh-pages because cancel-in-progress: true
was cancelling the workflow before the deployment step could complete.

- Split test job into 'test' (fast, no coverage) and 'coverage' (full)
- Coverage job has its own concurrency group with cancel-in-progress: false
- Coverage will now queue and complete even with frequent commits

Author: echobt

.github/workflows/ci.yml

@@ -50,6 +50,29 @@ jobs:
   test:
     name: Test
     runs-on: platform-runner
+    steps:
+      - uses: actions/checkout@v4
+      - uses: dtolnay/rust-toolchain@stable
+      - uses: taiki-e/install-action@v2
+        with:
+          tool: cargo-nextest
+      - uses: Swatinem/rust-cache@v2
+        with:
+          shared-key: "platform-ci"
+          save-if: false
+
+      - name: Run tests
+        run: cargo nextest run --workspace -E 'not (test(/live/) | test(/integration/))'
+
+  # Coverage runs in a separate job with its own concurrency group
+  # This prevents coverage deployment from being cancelled by new commits
+  coverage:
+    name: Coverage
+    runs-on: platform-runner
+    if: github.ref == 'refs/heads/main'
+    concurrency:
+      group: coverage-deploy
+      cancel-in-progress: false
     permissions:
       contents: write
     steps:
@@ -65,25 +88,18 @@ jobs:
           shared-key: "platform-ci"
           save-if: false
 
-      - name: Run tests
-        if: github.ref != 'refs/heads/main'
-        run: cargo nextest run --workspace -E 'not (test(/live/) | test(/integration/))'
-
       - name: Run tests with coverage
-        if: github.ref == 'refs/heads/main'
         run: |
           cargo llvm-cov nextest --workspace --json --output-path coverage.json -E 'not (test(/live/) | test(/integration/))'
           cargo llvm-cov report --html --output-dir coverage-html
 
       - name: Upload coverage HTML report
-        if: github.ref == 'refs/heads/main'
         uses: actions/upload-artifact@v4
         with:
           name: coverage-html
           path: coverage-html/
 
       - name: Publish coverage HTML to GitHub Pages
-        if: github.ref == 'refs/heads/main'
         uses: peaceiris/actions-gh-pages@v4
         with:
           github_token: ${{ secrets.GITHUB_TOKEN }}
@@ -92,7 +108,6 @@ jobs:
           keep_files: true
 
       - name: Generate and deploy coverage badge
-        if: github.ref == 'refs/heads/main'
         run: |
           COVERAGE=$(jq '.data[0].totals.lines.percent // 0 | round' coverage.json)
           echo "Coverage: $COVERAGE%"
@@ -103,8 +118,8 @@ jobs:
           else COLOR="red"; fi
           curl -s "https://img.shields.io/badge/coverage-${COVERAGE}%25-${COLOR}" > badges/coverage.svg
 
-      - uses: peaceiris/actions-gh-pages@v4
-        if: github.ref == 'refs/heads/main'
+      - name: Deploy coverage badge
+        uses: peaceiris/actions-gh-pages@v4
         with:
           github_token: ${{ secrets.GITHUB_TOKEN }}
           publish_dir: ./badges

crates/storage/src/dynamic.rs

@@ -328,10 +328,12 @@ impl DynamicStorage {
         let mut map = match existing {
             None => HashMap::new(),
             Some(StorageValue::Map(map)) => map,
-            Some(_) => return Err(MiniChainError::TypeMismatch(format!(
+            Some(_) => {
+                return Err(MiniChainError::TypeMismatch(format!(
                 "Cannot set map field on non-map value at key {:?}. Existing value is not a map.",
                 key
-            ))),
+            )))
+            }
         };
 
         map.insert(field.into(), value);