Merge pull request #15 from leonace924/fix/int-overflow

echobt · web-flow · commit 138fbf908d8e · 2026-01-09T02:41:15.000+04:00
fix: integer overflow in calculation
diff --git a/crates/consensus/src/stake_weighted_pbft.rs b/crates/consensus/src/stake_weighted_pbft.rs
@@ -118,7 +118,8 @@ impl StakeWeightedRoundState {
         }
         let approve_stake = self.approve_stake();
         // Require strictly more than 50% to prevent ties
-        approve_stake * 2 > total_stake
+        // Use division instead of multiplication to avoid overflow with large stake values
+        approve_stake > total_stake / 2
     }
 
     /// Check if rejection is certain (>50% reject stake)
@@ -127,7 +128,8 @@ impl StakeWeightedRoundState {
             return false;
         }
         let reject_stake = self.reject_stake();
-        reject_stake * 2 > total_stake
+        // Use division instead of multiplication to avoid overflow with large stake values
+        reject_stake > total_stake / 2
     }
 
     /// Get vote count (for logging)

Original file line number	Diff line number	Diff line change
`@@ -118,7 +118,8 @@ impl StakeWeightedRoundState {`
`118`	`118`	`}`
`119`	`119`	`let approve_stake = self.approve_stake();`
`120`	`120`	`// Require strictly more than 50% to prevent ties`
`121`		`- approve_stake * 2 > total_stake`
	`121`	`+ // Use division instead of multiplication to avoid overflow with large stake values`
	`122`	`+ approve_stake > total_stake / 2`
`122`	`123`	`}`
`123`	`124`
`124`	`125`	`/// Check if rejection is certain (>50% reject stake)`
`@@ -127,7 +128,8 @@ impl StakeWeightedRoundState {`
`127`	`128`	`return false;`
`128`	`129`	`}`
`129`	`130`	`let reject_stake = self.reject_stake();`
`130`		`- reject_stake * 2 > total_stake`
	`131`	`+ // Use division instead of multiplication to avoid overflow with large stake values`
	`132`	`+ reject_stake > total_stake / 2`
`131`	`133`	`}`
`132`	`134`
`133`	`135`	`/// Get vote count (for logging)`