Skip to content

[BUG] [v0.0.7] Clippy derivable_impls: Default for ValidationStatus in forge/agents/mod.rs #53275

@chris-dev77777

Description

@chris-dev77777

Project

cortex

Description

Manual impl Default for ValidationStatus (~132); default Passed matches first variant.

Error Message

Debug Logs

System Information

OS: Windows 11
RAM: 16 GB
CPU: Intel(R) Core(TM) i7-11700F @ 2.50GHz (16 CPUs), ~2.5GHz

Screenshots

https://github.com/chris-dev777/image/blob/main/46.mp4

Steps to Reproduce

cd to the repository root.

cargo clippy -p cortex-agents --all-targets -- -W clippy::derivable_impls
cargo clippy -p cortex-agents --all-targets -- -W clippy::derivable_impls 2>&1 | Select-String -Pattern "forge\agents\mod.rs:132|derivable_impls"

Expected Behavior

#[derive(Default)] on ValidationStatus or a documented allow.

Actual Behavior

With -W clippy::derivable_impls, Clippy warns on manual Default for ValidationStatus.

Additional Context

src/cortex-agents/src/forge/agents/mod.rs. At line 121, the ValidationStatus enum is defined with Passed as its first variant:

pub enum ValidationStatus {
/// Validation passed with no issues.
Passed,
// ...
}
At line 132, there is indeed a manual Default implementation:

impl Default for ValidationStatus {
fn default() -> Self {
Self::Passed
}
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workinginvalidThis doesn't seem right

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions