Build

chore: core no longer needs a repositories volume #435

Sign in to view logs

Triggered via push November 15, 2024 03:02

stakach

master

Status Success

Total duration 8m 26s

Artifacts –

This run and associated checks have been archived and are scheduled for deletion. Learn more about checks retention

build.yml

on: push

build-edge / Build

build-core / Build

Annotations

9 warnings and 33 notices

Documentation/DocumentationAdmonition: src/placeos-edge/protocol.cr#L93

Found a TODO admonition in a comment

Lint/UselessAssign: src/placeos-edge/protocol.cr#L21

Useless assignment to variable `sequence_id`

Lint/UselessAssign: src/placeos-edge/protocol.cr#L23

Useless assignment to variable `status`

Lint/UselessAssign: src/placeos-edge/protocol.cr#L24

Useless assignment to variable `length`

Lint/UselessAssign: src/placeos-edge/protocol.cr#L25

Useless assignment to variable `key`

Documentation/DocumentationAdmonition: src/placeos-core/module_manager.cr#L286

Found a TODO admonition in a comment

Documentation/DocumentationAdmonition: src/placeos-core/process_check.cr#L28

Found a TODO admonition in a comment

build-edge / Build

The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, docker/setup-qemu-action@v2, docker/setup-buildx-action@v2, docker/login-action@v2, docker/build-push-action@v4. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

build-core / Build

The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, docker/setup-qemu-action@v2, docker/setup-buildx-action@v2, docker/login-action@v2, docker/build-push-action@v4. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

Naming/BlockParameterName: src/edge-app.cr#L18

Disallowed block parameter name found

Naming/BlockParameterName: src/edge-app.cr#L20

Disallowed block parameter name found

Naming/BlockParameterName: src/core-app.cr#L17

Disallowed block parameter name found

Naming/BlockParameterName: src/core-app.cr#L18

Disallowed block parameter name found

Naming/BlockParameterName: src/core-app.cr#L20

Disallowed block parameter name found

Naming/BlockParameterName: src/placeos-core/healthcheck.cr#L25

Disallowed block parameter name found

Naming/BlockParameterName: src/placeos-core/process_manager/edge.cr#L160

Disallowed block parameter name found

Naming/BlockParameterName: src/placeos-edge/protocol.cr#L150

Disallowed block parameter name found

Naming/QueryBoolMethods: src/placeos-edge/protocol.cr#L386

Consider using 'getter?' for 'success'

Naming/BlockParameterName: src/placeos-core/driver_manager.cr#L106

Disallowed block parameter name found

Naming/BlockParameterName: spec/placeos-edge/client_spec.cr#L19

Disallowed block parameter name found

Naming/BlockParameterName: src/placeos-core/process_check.cr#L93

Disallowed block parameter name found

Naming/QueryBoolMethods: spec/helper.cr#L202

Consider using 'getter?' for 'unregister'

Naming/BlockParameterName: spec/api/command_spec.cr#L66

Disallowed block parameter name found

Naming/BlockParameterName: spec/processes/edge_spec.cr#L55

Disallowed block parameter name found

Naming/BlockParameterName: spec/processes/edge_spec.cr#L82

Disallowed block parameter name found

Naming/BlockParameterName: spec/processes/edge_spec.cr#L90

Disallowed block parameter name found

Naming/BlockParameterName: spec/processes/edge_spec.cr#L99

Disallowed block parameter name found

Naming/BlockParameterName: spec/processes/edge_spec.cr#L111

Disallowed block parameter name found

Naming/BlockParameterName: spec/processes/edge_spec.cr#L119

Disallowed block parameter name found

Naming/BlockParameterName: spec/processes/edge_spec.cr#L130

Disallowed block parameter name found

Naming/BlockParameterName: spec/processes/edge_spec.cr#L169

Disallowed block parameter name found

Naming/BlockParameterName: spec/processes/edge_spec.cr#L196

Disallowed block parameter name found

Naming/BlockParameterName: spec/processes/edge_spec.cr#L212

Disallowed block parameter name found

Naming/BlockParameterName: spec/processes/edge_spec.cr#L219

Disallowed block parameter name found

Naming/BlockParameterName: spec/processes/edge_spec.cr#L226

Disallowed block parameter name found

Naming/BlockParameterName: spec/processes/edge_spec.cr#L233

Disallowed block parameter name found

Naming/BlockParameterName: spec/processes/edge_spec.cr#L246

Disallowed block parameter name found

Naming/BlockParameterName: spec/processes/edge_spec.cr#L257

Disallowed block parameter name found

Naming/BlockParameterName: spec/processes/edge_spec.cr#L268

Disallowed block parameter name found

Naming/BlockParameterName: spec/processes/edge_spec.cr#L275

Disallowed block parameter name found

Naming/BlockParameterName: spec/processes/edge_spec.cr#L291

Disallowed block parameter name found

Naming/BlockParameterName: spec/mappings/driver_module_names_spec.cr#L18

Disallowed block parameter name found