Skip to content

Need a way of allowing queued snapshots to process when stopRecording is called #61

@jlack1987

Description

@jlack1987

Currently when stopRecording is called, the boolean run in DataSinkBase::Pimpl is set to false and snapshots stop being taken. This makes it tough on unit tests where you want all queued snapshots to be written to the mcap file and the file written to disk. Would be nice if either stopRecording allowed the queue to finish processing but would't add any more or a separate call was added that added this additional behavior. Without this I think brittle sleeps are the only way to try and ensure your sink has finished processing any outstanding snapshots before stopping it

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions