Skip to content

Drop try/except in get_param_groups_dataframes #449

@tsalo

Description

@tsalo

I'm currently testing out the dev branch, which combines the changes from #445 and #407, and I noticed that the cubids group output didn't include the fMRI scans. There wasn't any kind of warning that these files weren't being grouped, because we have a try/except statement get_param_groups_dataframes that just skips over entity sets that don't successfully group, without any kind of warning.

CuBIDS/cubids/cubids.py

Lines 1211 to 1219 in b172dd3

for entity_set in entity_sets:
try:
(
labeled_file_params,
param_summary,
modality,
) = self.get_param_groups_from_entity_set(entity_set)
except Exception:
continue

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions