fix: Clear shelf and topic filters when search bar is cleared

clearSearch() only reset the query text, leaving selectedShelf,
selectedTopic and their active filter types intact. Also, the search
bar's clear button called setSearchQuery('') instead of clearSearch().

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: Eoic

client/lib/pages/library_page.dart

@@ -356,7 +356,11 @@ class _LibraryPageState extends State<LibraryPage> {
       initialQuery: libraryProvider.searchQuery,
       activeFilterCount: activeFilters.length,
       onQueryChanged: (query) {
-        libraryProvider.setSearchQuery(query);
+        if (query.isEmpty) {
+          libraryProvider.clearSearch();
+        } else {
+          libraryProvider.setSearchQuery(query);
+        }
       },
       onFilterTap: () => isDesktop
           ? _showFilterDialog(context)

client/lib/providers/library_provider.dart

@@ -184,12 +184,17 @@ class LibraryProvider extends ChangeNotifier {
     }
   }
 
-  /// Clear the search query.
+  /// Clear the search query and associated shelf/topic filters.
   void clearSearch() {
-    if (_searchQuery.isNotEmpty) {
-      _searchQuery = '';
-      notifyListeners();
+    _searchQuery = '';
+    _selectedShelf = null;
+    _selectedTopic = null;
+    _activeFilters.remove(LibraryFilterType.shelves);
+    _activeFilters.remove(LibraryFilterType.topics);
+    if (_activeFilters.isEmpty) {
+      _activeFilters.add(LibraryFilterType.all);
     }
+    notifyListeners();
   }
 
   /// Select a shelf for filtering.

client/test/providers/library_provider_test.dart

@@ -123,6 +123,53 @@ void main() {
         provider.setSearchQuery('author:tolkien');
         expect(provider.hasActiveAdvancedFilters, true);
       });
+
+      test('should clear shelf and topic filters when clearing search', () {
+        // Simulate applying filters via the filter dialog:
+        // shelf filter sets selectedShelf + shelves filter type + query
+        provider.selectShelf('Fiction');
+        provider.setSearchQuery('shelf:"Fiction"');
+
+        // Simulate pressing the "X" clear button on the search bar
+        provider.clearSearch();
+
+        expect(provider.searchQuery, '');
+        expect(provider.selectedShelf, isNull);
+        expect(provider.isFilterActive(LibraryFilterType.shelves), false);
+        expect(provider.isFilterActive(LibraryFilterType.all), true);
+      });
+
+      test('should clear topic filter when clearing search', () {
+        provider.selectTopic('Science');
+        provider.setSearchQuery('topic:"Science"');
+
+        provider.clearSearch();
+
+        expect(provider.searchQuery, '');
+        expect(provider.selectedTopic, isNull);
+        expect(provider.isFilterActive(LibraryFilterType.topics), false);
+        expect(provider.isFilterActive(LibraryFilterType.all), true);
+      });
+
+      test('should clear all filter state when clearing search', () {
+        // Set up shelf/topic filters then add a quick filter chip on top
+        provider.selectShelf('Fiction');
+        provider.selectTopic('Science');
+        provider.addFilter(LibraryFilterType.reading);
+        provider.setSearchQuery(
+          'author:tolkien shelf:"Fiction" topic:"Science"',
+        );
+
+        provider.clearSearch();
+
+        expect(provider.searchQuery, '');
+        expect(provider.selectedShelf, isNull);
+        expect(provider.selectedTopic, isNull);
+        expect(provider.isFilterActive(LibraryFilterType.shelves), false);
+        expect(provider.isFilterActive(LibraryFilterType.topics), false);
+        // Reading filter was set via chip, not search — should be preserved
+        expect(provider.isFilterActive(LibraryFilterType.reading), true);
+      });
     });
 
     group('shelf and topic selection', () {