Microsoft.Cci.DummyTypeReference

[alexander-williamson]

When we generate files, we see Microsoft.Cci.DummyTypeReference in the parameters name.

      <match assemblyName="Company.FraudCheckService.Host" className="Company.FraudCheckService.Host.ActionFilters.ValidationActionFilter">
        <exactMethodMatcher methodName="OnActionExecuted" parameters="Microsoft.Cci.DummyTypeReference" />
        <exactMethodMatcher methodName="OnActionExecuting" parameters="Microsoft.Cci.DummyTypeReference" />
      </match>

Which is wrong because in this case the value for this parameter should be Microsoft.AspNetCore.Mvc.Filters.ActionExecutingContext

The current .NET Agent extension.xsd file which New Relic documentation states we should validate against has an interesting comment for the parameters which makes me think they're not needed anyway.

<xs:attribute name="parameters" type="xs:string" use="optional">
  <xs:annotation>
    <xs:documentation>
      The method parameters to match.  This is optional, and should only be used when a 
      method is overloaded and you want to instrument a specific version of the method.
    </xs:documentation>
  </xs:annotation>
</xs:attribute>

Is there a flag to ignore these unnecessary method parameters that I can pass to the command so they are not emitted? What's your preference for a PR if I'd like to add this as a feature?

[alexander-williamson]

We've tested this internally and we are using versions without parameters for our services.