Skip to content

Front-end: Problem with themes and colours #91

@m0rtalmike

Description

@m0rtalmike

Image

  • I wanted to play around with the colours before using the PreLight theme in view > Theme.kt and noticed some colour discrepancies.

  • Instead of deadset colour values for each section of the application I suggested a global constant value for Hex colours for themes, so theme or colour changes will be universal across the whole application.

  • I also suggested manipulating each colour's Hex value instead of deadsetting a lighter (or darker depending on the theme) colour for box and text selection for the same reason but also to make making themes easier. The level of manipulation can be fine-tuned by eye, and whether it is darker / lighter depends on the theme and can be a binary value added to the theme class (e.g. "theme.dark = True").

  • Tom suggested that another colour representation instead of Hex (such as RGB) could be possible further down the line. It may be easier to manipulate the values this way.

  • Tom also suggested there may be a library to address my concerns, this needs to be followed up.

Summary

  • Colour discrepancies between app sections from potential deadset colour values.
  • Global variables to set these for each theme would solve this and streamline front-end.
  • Deadset values for highlighted box and text colours could be fixed by manipulated colour values directly.
  • Different representation of colour (Hex) could be possible further down the line.
  • Library(s) may be available to solve these issues

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions