Skip to content

Compiling pointops without THC #73

@maxim0815

Description

@maxim0815

Hey thanks for the code. I don't want to draw attention to a bug here, but just mention a small thing.

I just tried compiling pointops and ran into the following error:

src/knnquery/knnquery_cuda.cpp:2:10: fatal error: THC/THC.h: No such file or directory
    2 | #include <THC/THC.h>
      |          ^~~~~~~~~~~
compilation terminated.
error: command 'x86_64-linux-gnu-gcc' failed with exit status 1

According to this post "TH/THC namespace is dead". Removing the includes for THC within all .cpp files and recompiling works fine. It is therefore no longer required for newer cuda versions.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions