chore: PR #30 review fixes — remove .cursor artifact, async _delete via _call + 204

- Remove .cursor/plans/purely_async_er2er_f2b9c60a.plan.md (IDE artifact)
- Add .cursor/ to .gitignore to prevent recurrence
- Async _delete: delegate to _call() with 204 and DELETE 409 handling in _call
- Update async test for 500 to accept ERClientInternalError message

Co-authored-by: Cursor <cursoragent@cursor.com>

Author: JoshuaVulcan

.cursor/plans/purely_async_er2er_f2b9c60a.plan.md

@@ -104,3 +104,6 @@ ENV/
 
 # Pycharm .idea folder
 .idea/
+
+# Cursor IDE artifacts
+.cursor/

.gitignore

@@ -1686,44 +1686,10 @@ async def _get_data(self, endpoint, params, batch_size=0):
     async def _get(self, path, base_url=None, params=None):
         return await self._call(path=path, payload=None, method="GET", params=params, base_url=base_url)
 
-    async def _delete(self, path, base_url=None):
-        """Issue DELETE request. Returns True on success; raises ERClient* on error."""
-        try:
-            auth_headers = await self.auth_headers()
-        except httpx.HTTPStatusError as e:
-            self._handle_http_status_error(path, "DELETE", e)
-        headers = {'User-Agent': self.user_agent, **auth_headers}
-        if not path.startswith('http'):
-            path = self._er_url(path, base_url)
-        try:
-            response = await self._http_session.delete(path, headers=headers)
-        except httpx.RequestError as e:
-            reason = str(e)
-            self.logger.error('Request to ER failed', extra=dict(provider_key=self.provider_key,
-                                                                 url=path,
-                                                                 reason=reason))
-            raise ERClientException(f'Request to ER failed: {reason}')
-        if response.is_success:
-            return True
-        if response.status_code == 404:
-            self.logger.error("404 when calling %s", path)
-            raise ERClientNotFound()
-        if response.status_code == 403:
-            try:
-                reason = response.json().get('status', {}).get('detail', 'unknown reason')
-            except Exception:
-                reason = 'unknown reason'
-            raise ERClientPermissionDenied(reason)
-        if response.status_code == 409:
-            try:
-                detail = response.json().get('detail', response.text)
-            except Exception:
-                detail = response.text
-            raise ERClientException(
-                f'Cannot delete: {detail}',
-            )
-        raise ERClientException(
-            f'Failed to delete: {response.status_code} {response.text}'
+    async def _delete(self, path, base_url=None, params=None):
+        """Issue DELETE request via _call. Returns True on 204; raises ERClient* on error."""
+        return await self._call(
+            path=path, payload=None, method="DELETE", params=params, base_url=base_url
         )
 
     async def get_file(self, url):
@@ -1788,6 +1754,14 @@ async def _call(self, path, payload, method, params=None, base_url=None):
                     params=params,
                     headers=headers
                 )
+                if response.status_code == 204:
+                    return True
+                if response.status_code == 409 and method == "DELETE":
+                    try:
+                        detail = response.json().get("detail", response.text)
+                    except Exception:
+                        detail = response.text
+                    raise ERClientException(f"Cannot delete: {detail}")
                 response.raise_for_status()
             except httpx.RequestError as e:
                 # Network errors, timeouts

erclient/client.py

@@ -165,7 +165,7 @@ async def test_delete_event_type_server_error_raises(er_client):
             text="Internal Server Error"
         )
 
-        with pytest.raises(ERClientException, match="Failed to delete"):
+        with pytest.raises(ERClientException, match="500|Internal Server Error"):
             await er_client.delete_event_type(slug)
 
         assert route.called