All tags bug

[leogianfagna]

There is a bug that shows all the tags in categories menu, if the player loses the permission for the current tag.

YAML configs

default-tag: random
remove-inaccessible-tags: true

How to reproduce

1 - Give a tag permission and use it

Give the tag permission eternaltags.tag.atrapalhada. Apply the tag. For a more realist example, give another tag, in my case I will give eternaltags.tag.membro.

2 - Check the category menu for that tag

Here it is

3 - Remove the permission

Remove eternaltags.tag.atrapalhada permission. The player will lose his tag.

4 - Check the category menu

Use /tags categories and go to the tag's category. Here it is:

For some reason, now there is ALL tags from that category.

5 - Select any tag that you don't have

I picked up any tag, I don't have permission for it. It's not showing on tab, but it says that I selected it.

6 - Now, select a tag that you have

I gave back my eternaltags.tag.atrapalhada permission and now I will apply that tag. I searched in menu:

7 - Check results

The tag is properly applied:

And now the menu got fixed:

Conclusion

I may be wrong but maybe is something related to getRandomTag() in TagsManager.java. I don't know. I'm using the latest version from Spigot. If you have any idea of the cause, I could try to fix and make a pr.

[Momshroom]

I am having this issue as well, and we are not using random tags.

Players who do not have a tag, for example, used /tags clear, can choose any tag irregardless of their permissions.

EternalTags version 1.3.3
Paper version 1.21.8-60-main@29c8822

[Momshroom]

if I change remove-inaccessible-tags to true in the config, the bug still exists in that when they have no tag they get all the choices, but it does prevent the tag from sticking once they choose it if they don't have perms. (It tells them they've applied it, but it no longer shows.). This is a big improvement, but not a complete fix. Thought it might help anyone else experiencing this issue.