refactor: simplify hallucination stripping

Author: Tarquinen

index.ts

@@ -67,7 +67,7 @@ const plugin: Plugin = (async (ctx) => {
             hostPermissions,
         ) as any,
         "chat.message": createChatMessageHandler(state, logger, config, hostPermissions),
-        "experimental.text.complete": createTextCompleteHandler(state, config),
+        "experimental.text.complete": createTextCompleteHandler(),
         "command.execute.before": createCommandExecuteHandler(
             ctx.client,
             state,

lib/hooks.ts

@@ -103,7 +103,7 @@ export function createChatMessageTransformHandler(
             return
         }
 
-        stripHallucinations(output.messages, state, config)
+        stripHallucinations(output.messages)
         cacheSystemPromptTokens(state, output.messages)
         assignMessageRefs(state, output.messages)
         syncCompressionBlocks(state, logger, output.messages)
@@ -255,15 +255,11 @@ export function createCommandExecuteHandler(
     }
 }
 
-export function createTextCompleteHandler(state: SessionState, config: PluginConfig) {
+export function createTextCompleteHandler() {
     return async (
         _input: { sessionID: string; messageID: string; partID: string },
         output: { text: string },
     ) => {
-        if (compressPermission(state, config) === "deny") {
-            return
-        }
-
         output.text = stripHallucinationsFromString(output.text)
     }
 }

lib/messages/utils.ts

@@ -1,6 +1,5 @@
 import { createHash } from "node:crypto"
 import type { PluginConfig } from "../config"
-import { compressPermission } from "../shared-utils"
 import { isMessageCompacted } from "../shared-utils"
 import type { SessionState, WithParts } from "../state"
 import type { UserMessage } from "@opencode-ai/sdk/v2"
@@ -188,15 +187,7 @@ export const stripHallucinationsFromString = (text: string): string => {
     return text.replace(DCP_PAIRED_TAG_REGEX, "").replace(DCP_UNPAIRED_TAG_REGEX, "")
 }
 
-export const stripHallucinations = (
-    messages: WithParts[],
-    state: SessionState,
-    config: PluginConfig,
-): void => {
-    if (compressPermission(state, config) === "deny") {
-        return
-    }
-
+export const stripHallucinations = (messages: WithParts[]): void => {
     for (const message of messages) {
         for (const part of message.parts) {
             if (part.type === "text" && typeof part.text === "string") {

tests/hooks-permission.test.ts

@@ -80,7 +80,7 @@ function buildMessage(id: string, role: "user" | "assistant", text: string): Wit
     }
 }
 
-test("chat message transform leaves messages untouched when compress is denied", async () => {
+test("chat message transform strips hallucinated tags even when compress is denied", async () => {
     const state = createSessionState()
     const logger = new Logger(false)
     const config = buildConfig("deny")
@@ -104,7 +104,7 @@ test("chat message transform leaves messages untouched when compress is denied",
     await handler({}, output)
 
     assert.equal(output.messages[0]?.parts[0]?.type, "text")
-    assert.equal((output.messages[0]?.parts[0] as any).text, "alpha <dcp>beta</dcp> omega")
+    assert.equal((output.messages[0]?.parts[0] as any).text, "alpha  omega")
 })
 
 test("command execute exits after effective permission resolves to deny", async () => {
@@ -144,11 +144,11 @@ test("chat message hook caches variant even when effective permission is denied"
     assert.equal(state.variant, "danger")
 })
 
-test("text complete leaves output untouched when compress is denied", async () => {
+test("text complete strips hallucinated metadata tags", async () => {
     const output = { text: "alpha <dcp>beta</dcp> omega" }
-    const handler = createTextCompleteHandler(createSessionState(), buildConfig("deny"))
+    const handler = createTextCompleteHandler()
 
     await handler({ sessionID: "session-1", messageID: "message-1", partID: "part-1" }, output)
 
-    assert.equal(output.text, "alpha <dcp>beta</dcp> omega")
+    assert.equal(output.text, "alpha  omega")
 })

tests/message-priority.test.ts

@@ -776,7 +776,7 @@ test("hallucination stripping removes all dcp-prefixed XML tags including varian
 
     assert.equal(stripHallucinationsFromString(text), "alphaomega")
 
-    const handler = createTextCompleteHandler(createSessionState(), buildConfig())
+    const handler = createTextCompleteHandler()
     const output = { text }
     await handler({ sessionID: "session", messageID: "message", partID: "part" }, output)
     assert.equal(output.text, "alphaomega")