From 1f84ea7997387ec89aaa749d92e0c0869cfc057b Mon Sep 17 00:00:00 2001 From: Ben Ford Date: Tue, 2 Dec 2025 14:29:41 -0800 Subject: [PATCH] cleaner local facts filter Just a trivial refactor that I forgot to do before submitting #240 --- lib/puppet/node/facts.rb | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/lib/puppet/node/facts.rb b/lib/puppet/node/facts.rb index 1492402fd4..241840e51d 100644 --- a/lib/puppet/node/facts.rb +++ b/lib/puppet/node/facts.rb @@ -29,10 +29,12 @@ def save(instance, key = nil, options = {}) def add_local_facts(query = []) query = Array(query) # some use cases result in a nil being passed in - values["implementation"] = Puppet.implementation if query.empty? or query.include? 'implementation' - values["clientcert"] = Puppet.settings[:certname] if query.empty? or query.include? 'clientcert' - values["clientversion"] = Puppet.version.to_s if query.empty? or query.include? 'clientversion' - values["clientnoop"] = Puppet.settings[:noop] if query.empty? or query.include? 'clientnoop' + return if query.empty? + + values["implementation"] = Puppet.implementation if query.include? 'implementation' + values["clientcert"] = Puppet.settings[:certname] if query.include? 'clientcert' + values["clientversion"] = Puppet.version.to_s if query.include? 'clientversion' + values["clientnoop"] = Puppet.settings[:noop] if query.include? 'clientnoop' end def initialize(name, values = {})