test: remove duplicate and theatrical tests

Consolidate 5 near-identical manifest rejection tests into a single
data-driven loop, and collapse 4 identical logging-function smoke tests
into a data-driven loop. Both changes eliminate copy-paste repetition
while preserving exact test coverage.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: 2 people

packages/cli/src/__tests__/manifest.test.ts

@@ -208,52 +208,33 @@ describe("manifest", () => {
       await expect(loadManifest(true)).rejects.toThrow("Cannot load manifest");
     });
 
-    it("throws when manifest from GitHub is invalid", async () => {
-      const consoleSpy = spyOn(console, "error").mockImplementation(() => {});
-      global.fetch = mock(
-        async () =>
+    const invalidManifestCases: Array<{
+      label: string;
+      fetchImpl: () => Promise<Response>;
+    }> = [
+      {
+        label: "non-manifest shape",
+        fetchImpl: async () =>
           new Response(
             JSON.stringify({
               not: "a manifest",
             }),
           ),
-      );
-
-      const cacheFile = join(env.testDir, "spawn", "manifest.json");
-      if (existsSync(cacheFile)) {
-        rmSync(cacheFile);
-      }
-
-      await expect(loadManifest(true)).rejects.toThrow("Cannot load manifest");
-      consoleSpy.mockRestore();
-    });
-
-    it("rejects manifest with string agents field", async () => {
-      const consoleSpy = spyOn(console, "error").mockImplementation(() => {});
-      global.fetch = mock(
-        async () =>
+      },
+      {
+        label: "string agents field",
+        fetchImpl: async () =>
           new Response(
             JSON.stringify({
               agents: "claude",
               clouds: {},
               matrix: {},
             }),
           ),
-      );
-
-      const cacheFile = join(env.testDir, "spawn", "manifest.json");
-      if (existsSync(cacheFile)) {
-        rmSync(cacheFile);
-      }
-
-      await expect(loadManifest(true)).rejects.toThrow("Cannot load manifest");
-      consoleSpy.mockRestore();
-    });
-
-    it("rejects manifest with array clouds field", async () => {
-      const consoleSpy = spyOn(console, "error").mockImplementation(() => {});
-      global.fetch = mock(
-        async () =>
+      },
+      {
+        label: "array clouds field",
+        fetchImpl: async () =>
           new Response(
             JSON.stringify({
               agents: {},
@@ -264,53 +245,38 @@ describe("manifest", () => {
               matrix: {},
             }),
           ),
-      );
-
-      const cacheFile = join(env.testDir, "spawn", "manifest.json");
-      if (existsSync(cacheFile)) {
-        rmSync(cacheFile);
-      }
-
-      await expect(loadManifest(true)).rejects.toThrow("Cannot load manifest");
-      consoleSpy.mockRestore();
-    });
-
-    it("rejects manifest with numeric matrix field", async () => {
-      const consoleSpy = spyOn(console, "error").mockImplementation(() => {});
-      global.fetch = mock(
-        async () =>
+      },
+      {
+        label: "numeric matrix field",
+        fetchImpl: async () =>
           new Response(
             JSON.stringify({
               agents: {},
               clouds: {},
               matrix: 42,
             }),
           ),
-      );
-
-      const cacheFile = join(env.testDir, "spawn", "manifest.json");
-      if (existsSync(cacheFile)) {
-        rmSync(cacheFile);
-      }
-
-      await expect(loadManifest(true)).rejects.toThrow("Cannot load manifest");
-      consoleSpy.mockRestore();
-    });
-
-    it("throws when network errors occur and no cache exists", async () => {
-      const consoleSpy = spyOn(console, "error").mockImplementation(() => {});
-      global.fetch = mock(async () => {
-        throw new Error("Network timeout");
+      },
+      {
+        label: "network error",
+        fetchImpl: async () => {
+          throw new Error("Network timeout");
+        },
+      },
+    ];
+
+    for (const { label, fetchImpl } of invalidManifestCases) {
+      it(`rejects invalid manifest (${label})`, async () => {
+        const consoleSpy = spyOn(console, "error").mockImplementation(() => {});
+        global.fetch = mock(fetchImpl);
+        const cacheFile = join(env.testDir, "spawn", "manifest.json");
+        if (existsSync(cacheFile)) {
+          rmSync(cacheFile);
+        }
+        await expect(loadManifest(true)).rejects.toThrow("Cannot load manifest");
+        consoleSpy.mockRestore();
       });
-
-      const cacheFile = join(env.testDir, "spawn", "manifest.json");
-      if (existsSync(cacheFile)) {
-        rmSync(cacheFile);
-      }
-
-      await expect(loadManifest(true)).rejects.toThrow("Cannot load manifest");
-      consoleSpy.mockRestore();
-    });
+    }
   });
 });
 

packages/cli/src/__tests__/ui-cov.test.ts

@@ -62,25 +62,34 @@ afterEach(() => {
 // ── Logging functions ──────────────────────────────────────────────
 
 describe("logging functions", () => {
-  it("logInfo writes green text to stderr", () => {
-    logInfo("test info");
-    expect(stderrOutput.join("")).toContain("test info");
-  });
-
-  it("logWarn writes yellow text to stderr", () => {
-    logWarn("test warn");
-    expect(stderrOutput.join("")).toContain("test warn");
-  });
-
-  it("logError writes red text to stderr", () => {
-    logError("test error");
-    expect(stderrOutput.join("")).toContain("test error");
-  });
-
-  it("logStep writes cyan text to stderr", () => {
-    logStep("test step");
-    expect(stderrOutput.join("")).toContain("test step");
-  });
+  for (const [fn, msg] of [
+    [
+      logInfo,
+      "test info",
+    ],
+    [
+      logWarn,
+      "test warn",
+    ],
+    [
+      logError,
+      "test error",
+    ],
+    [
+      logStep,
+      "test step",
+    ],
+  ] satisfies Array<
+    [
+      (msg: string) => void,
+      string,
+    ]
+  >) {
+    it(`${fn.name} writes message to stderr`, () => {
+      fn(msg);
+      expect(stderrOutput.join("")).toContain(msg);
+    });
+  }
 
   it("logStepInline writes message (newline-terminated in non-TTY)", () => {
     logStepInline("inline msg");