User adds a custom generated-features.xml file in dev mode

[turkeylurkey]

We are wondering if it is safe to delete src/main/liberty/config/configDropins/overrides/generated-features.xml when the user toggles the generateToSrc option in dev mode.

It is not possible to have generateToSrc option true and to have a custom generated-features.xml file in the src/main/liberty/config directory. Any change to files in the config directory will cause dev mode to run the generate-features mojo and overwrite the generated-features.xml file. Therefore when you toggle generateToSrc option from true to false and dev mode deletes the generated-features.xml file (no longer used) it should not be possible for there to be a custom file in that location.

Furthermore, if the generateToSrc option is false and the user adds a custom generated-features.xml file in the src/main/liberty/config directory there will be a collision in the server dir. Both the custom file and the file dev mode generates need to be written to the same location in target/liberty/wlp/usr/servers/defaultServer/configDropins/overrides.

[TrevCraw]

Given that for both the generate to source and generate to server scenarios users should not have a file named generated-features.xml in the configDropins/overrides location, we should document that this is a reserved filename when users are using feature gen.