When using generateToSrc=false changes to server.xml are not recognized

[turkeylurkey]

You can change server.xml in src dir but generate features uses the server.xml in the server dir to generate features.

Dev mode will copy server.xml from src dir to server dir after the features are generated so subsequent calls to generate features will use the new server.xml.

Using a single module in this case.

[turkeylurkey]

Design

Combine the current config with the file detected as modified (by dev mode) in the temp directory reserved for generate features mojo.

This is required when generateToSrc is false. In this case the feature gen. context (i.e. the liberty config) is the server dir in the target directory. Thus the requirement is to copy the liberty config in the server dir into the GF temp dir. Then copy the modified file (user modifies files in src dir) into the GF temp dir. Then use this config as the context (the input data) for generate features mojo. GF mojo already ignores the generate-features.xml file in the config if 'optimize' is on.

To signal this behaviour to the generate features mojo is a new parameter called 'useTempDirAsContext'. To keep things understandable we will rename the parameter “useTempDir” to be “userTempDirAsOutput”. This way, the two things the temp dir is used for is reflected in the name of the parameter. These parameters are not intended for users and they are undocumented.

We will only copy the liberty config to the GF temp dir in the case that a config file is changed. If some other file is changed we will continue to use the liberty config in its normal location in the server dir in the target dir. This is for performance reasons, only copy the files when needed for correctness.