InitializationException with ODDR Data release 1.32

[retohugi]

Running the console application of the OpenDDR-Simple solution hits an exception when running againt the 1.32 release file-set, it works fine with the 1.31 release though.
I'm super new to this project and am not yet capable of giving a more qualified answer or even issue a PR. So here's the exception I get:

W3c.Ddr.Exceptions.InitializationException
  HResult=0x80131500
  Message=
  Source=<Cannot evaluate the exception source>
  StackTrace:
<Cannot evaluate the exception stack trace>

Inner Exception 1:
Exception: Can not parse oddr.ua.device.builder.path: C:\devicedetection\devicedata\BuilderDataSource.xml

As said, replacing all the files in the devicedata directory with the 1.31 release package works.

[keilw]

Will try to reproduce. Did you also try the C# Classifier?

[Nacer-]

Hello,
Big thanks to you.
I just tried Openddr csharp and a I have the same problem with data version 1.32. Exception Oddr.Documenthandlers.DeviceBuilderParser.Parse() ... OpenDDR-CSharp\Documenthandlers\DeviceBuilderParser.cs:line 165

Openddr-Data version 1.31 works well.

I think it's because of the BuilderDataSource.xml file: line 14501, device id = PLAYSTATION_2 contains a single child value. It must contain 2 childs value.

        ...
     <device id="Nokia300">
            <list>
                <value>Nokia</value>
                <value>300</value>
            </list>
        </device>
        <device id="PLAYSTATION_2">
            <list>
                <value>PS2</value>
            </list>
        </device>
        <device id="PLAYSTATION_3">
            <list>
                <value>PLAYSTATION</value>
                <value>3</value>
            </list>
        </device>
        ...

Class \simple\OpenDDR-CSharp\Builders\DevicesTwoStepDeviceBuilder.cs line 163: List initProperties must have 2 items.

    ....
    public override void PutDevice(string deviceID, List<string> initProperties)
    {
        String step1TokenString = initProperties[0];
        String step2TokenString = initProperties[1];
     ....

.

I added value PLAYSTATION in file BuilderDataSource.xml line 14503 and openddr-data-1.32 is ok.

        <device id="PLAYSTATION_2">
            <list>
                <value>PLAYSTATION</value>
                <value>PS2</value>
            </list>
        </device>

Is this correct ?

Thank you again.

Best regards.

[keilw]

Thanks, that sounds like a reason.
Would you be willing and able to submit a PR for it?

[Nacer-]

Hello Dear Keilw,

I am wiling for any contribution with pleasure but i'm not able to submit a PR (PR is Pull Request?).

After click "New pull request", I do not know how to continue.

you control the use of github, unlike me :). I really do not know what to do. Can you do it please.

Best regards

[keilw]

Hi @Nacer- ,
Thanks for the reply. A PR is only possible if you work either on a different branch in this repository or a fork in your own user space like "Nacer/openddr-csharp". Did you fork either of the repositories? Then it should work to propose a PR based on your changes there.

HTH,
Werner

[Nacer-]

Hi Dear Werner,

I dont fork any repositories. I work with your csharp version downloaded from https://github.com/OpenDDRmobi/openddr-csharp/archive/master.zip
and data-version from https://github.com/OpenDDRmobi/openddr-data/archive/1.32.zip
I just changed the version of log4net and compiled the source for framework 4.5.

I think the source of problem mentioned by Reto Hugi is in the file BuilderDataSource.xml.

I will download data version 1-33 https://github.com/OpenDDRmobi/openddr-data/archive/master.zip and try it.

Thank you and my best regards.

[keilw]

Thanks for the input and analysis, it may help others to patch it where necessary.

Btw at the moment we only released data 1.32, but please use the latest snapshot and if there are improvements in the data just let us know.

[Nacer-]

I saw that I accidentally created a forkn,i delete it. Your version exceeds my needs.
I will use the latest snapshot and tell you news.

Many thanks Dear Wrner.

Best regards

Nacer

[keilw]

@Nacer- Thanks a lot for the detailed analysis.
So it may be data-related. I just added the extra line in question.
And after adding a few more devices, I plan a new 1.33 release of OpenDDR-Data that should address the problem.

[Nacer-]

That's great.
It is I who thank you very much.

Nacer.

[keilw]

Thanks again. The TwoStepBuilder as the name says requires at least two parts, that's correct. We may run some tests at least against certain parts of files like BuilderDataSource.xml. If you have an idea or want to contribute, please help. The "Independence Day Release" 1.33 will fix the mentioned problem. And except maybe a follow-up for data tests, I guess I'll close the bug once the new release is out.