Skip to content

clarification of warnings in ComputeDiffusionParameters #753

@ragusa

Description

@ragusa

Often, one can see this:
*** WARNING *** Negative transport cross section found for group 0 in call to ComputeDiffusionParameters. sigma_t=0 sigma_1=0. Setting sigma_1=0, sigma_tr=sigma_t for this group.

I propose the following:

  1. first, the above printout should be moved inside the loop if (S.size() > 1) because there's no reason for that warning to show when only isotropic scattering XS are used
  2. the code computes sigma_tr_[g] = sigma_t_[g] - sigma_1 but then keeps on using sigma_t_[g] - sigma_1 afterwards, why? not clean.
  3. add another warning just before computing D when |sigma_tr_[g]|<eps starting what value is being used instead of 0

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions