`arsenik.h:311:6: error: #error "Arsenik: Unknown layout"` when building for keychron q10 pro

[clementpoiret]

Hi, thanks a lot for arsenik.

I am trying to build it for my q10 pro using qmk but I get:

arm-none-eabi-gcc (Arm GNU Toolchain 12.3.Rel1 (Build arm-12.35)) 12.3.1 20230626
Copyright (C) 2022 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Generating: .build/obj_keychron_q10_pro_ansi_encoder_arsenik/src/info_config.h                      [OK]
Generating: .build/obj_keychron_q10_pro_ansi_encoder_arsenik/src/default_keyboard.c                 [OK]
Generating: .build/obj_keychron_q10_pro_ansi_encoder_arsenik/src/default_keyboard.h                 [OK]
Compiling: keyboards/keychron/bluetooth/bluetooth.c                                                 [OK]
Compiling: keyboards/keychron/bluetooth/report_buffer.c                                             [OK]
Compiling: keyboards/keychron/bluetooth/ckbt51.c                                                    [OK]
Compiling: keyboards/keychron/bluetooth/indicator.c                                                 [OK]
Compiling: keyboards/keychron/bluetooth/bluetooth_main.c                                            [OK]
Compiling: keyboards/keychron/bluetooth/transport.c                                                 [OK]
Compiling: keyboards/keychron/bluetooth/lpm.c                                                       [OK]
Compiling: keyboards/keychron/bluetooth/lpm_stm32l432.c                                             [OK]
Compiling: keyboards/keychron/bluetooth/battery.c                                                   [OK]
Compiling: keyboards/keychron/bluetooth/factory_test.c                                              [OK]
Compiling: keyboards/keychron/bluetooth/bat_level_animation.c                                       [OK]
Compiling: keyboards/keychron/bluetooth/rtc_timer.c                                                 [OK]
Compiling: keyboards/keychron/common/matrix.c                                                       [OK]
Compiling: keyboards/keychron/q10_pro/q10_pro.c                                                     [OK]
Compiling: keyboards/keychron/q10_pro/ansi_encoder/ansi_encoder.c                                   [OK]
Compiling: .build/obj_keychron_q10_pro_ansi_encoder_arsenik/src/default_keyboard.c                  [OK]
Compiling: quantum/keymap_introspection.c                                                          In file included from ./keyboards/keychron/q10_pro/ansi_encoder/keymaps/arsenik/keymap.c:2,
                 from quantum/keymap_introspection.c:5:
./keyboards/keychron/q10_pro/ansi_encoder/keymaps/arsenik/arsenik.h:311:6: error: #error "Arsenik: Unknown layout"
  311 | #    error "Arsenik: Unknown layout"
      |      ^~~~~
./keyboards/keychron/q10_pro/ansi_encoder/keymaps/arsenik/keymap.c:34:15: error: implicit declaration of function 'ARSENIK_LAYOUT'; did you mean 'ARSENIK_LAYOUT_90_ansi'? [-Werror=implicit-function-declaration]
   34 |     [_base] = ARSENIK_LAYOUT(
      |               ^~~~~~~~~~~~~~
      |               ARSENIK_LAYOUT_90_ansi
./keyboards/keychron/q10_pro/ansi_encoder/keymaps/arsenik/keymap.c:34:15: error: initializer element is not constant
./keyboards/keychron/q10_pro/ansi_encoder/keymaps/arsenik/keymap.c:34:15: note: (near initialization for 'keymaps[0][0][0]')
./keyboards/keychron/q10_pro/ansi_encoder/keymaps/arsenik/keymap.c:42:20: error: initializer element is not constant
   42 |     [_lafayette] = ARSENIK_LAYOUT(
      |                    ^~~~~~~~~~~~~~
./keyboards/keychron/q10_pro/ansi_encoder/keymaps/arsenik/keymap.c:42:20: note: (near initialization for 'keymaps[1][0][0]')
./keyboards/keychron/q10_pro/ansi_encoder/keymaps/arsenik/keymap.c:51:18: error: initializer element is not constant
   51 |     [_num_row] = ARSENIK_LAYOUT(
      |                  ^~~~~~~~~~~~~~
./keyboards/keychron/q10_pro/ansi_encoder/keymaps/arsenik/keymap.c:51:18: note: (near initialization for 'keymaps[2][0][0]')
./keyboards/keychron/q10_pro/ansi_encoder/keymaps/arsenik/keymap.c:59:18: error: initializer element is not constant
   59 |     [_vim_nav] = ARSENIK_LAYOUT(
      |                  ^~~~~~~~~~~~~~
./keyboards/keychron/q10_pro/ansi_encoder/keymaps/arsenik/keymap.c:59:18: note: (near initialization for 'keymaps[3][0][0]')
./keyboards/keychron/q10_pro/ansi_encoder/keymaps/arsenik/keymap.c:67:18: error: initializer element is not constant
   67 |     [_num_nav] = ARSENIK_LAYOUT(
      |                  ^~~~~~~~~~~~~~
./keyboards/keychron/q10_pro/ansi_encoder/keymaps/arsenik/keymap.c:67:18: note: (near initialization for 'keymaps[4][0][0]')
./keyboards/keychron/q10_pro/ansi_encoder/keymaps/arsenik/keymap.c:75:18: error: initializer element is not constant
   75 |     [_fun_pad] = ARSENIK_LAYOUT(
      |                  ^~~~~~~~~~~~~~
./keyboards/keychron/q10_pro/ansi_encoder/keymaps/arsenik/keymap.c:75:18: note: (near initialization for 'keymaps[6][0][0]')
quantum/keymap_introspection.c: In function 'encodermap_layer_count_raw':
quantum/keymap_introspection.c:49:56: error: invalid application of 'sizeof' to incomplete type 'const uint16_t[][1][2]' {aka 'const short unsigned int[][1][2]'}
   49 | #    define NUM_ENCODERMAP_LAYERS_RAW ((uint8_t)(sizeof(encoder_map) / ((NUM_ENCODERS) * (NUM_DIRECTIONS) * sizeof(uint16_t))))
      |                                                        ^
quantum/keymap_introspection.c:52:12: note: in expansion of macro 'NUM_ENCODERMAP_LAYERS_RAW'
   52 |     return NUM_ENCODERMAP_LAYERS_RAW;
      |            ^~~~~~~~~~~~~~~~~~~~~~~~~
quantum/keymap_introspection.c: At top level:
quantum/keymap_introspection.c:49:56: error: invalid application of 'sizeof' to incomplete type 'const uint16_t[][1][2]' {aka 'const short unsigned int[][1][2]'}
   49 | #    define NUM_ENCODERMAP_LAYERS_RAW ((uint8_t)(sizeof(encoder_map) / ((NUM_ENCODERS) * (NUM_DIRECTIONS) * sizeof(uint16_t))))
      |                                                        ^
quantum/keymap_introspection.c:59:41: note: in expansion of macro 'NUM_ENCODERMAP_LAYERS_RAW'
   59 | _Static_assert(NUM_KEYMAP_LAYERS_RAW == NUM_ENCODERMAP_LAYERS_RAW, "Number of encoder_map layers doesn't match the number of keymap layers");
      |                                         ^~~~~~~~~~~~~~~~~~~~~~~~~
quantum/keymap_introspection.c:17:31: error: expression in static assertion is not an integer
   17 | #define NUM_KEYMAP_LAYERS_RAW ((uint8_t)(sizeof(keymaps) / ((MATRIX_ROWS) * (MATRIX_COLS) * sizeof(uint16_t))))
      |                               ^
quantum/keymap_introspection.c:59:16: note: in expansion of macro 'NUM_KEYMAP_LAYERS_RAW'
   59 | _Static_assert(NUM_KEYMAP_LAYERS_RAW == NUM_ENCODERMAP_LAYERS_RAW, "Number of encoder_map layers doesn't match the number of keymap layers");
      |                ^~~~~~~~~~~~~~~~~~~~~
quantum/keymap_introspection.c: In function 'keycode_at_encodermap_location_raw':
quantum/keymap_introspection.c:49:56: error: invalid application of 'sizeof' to incomplete type 'const uint16_t[][1][2]' {aka 'const short unsigned int[][1][2]'}
   49 | #    define NUM_ENCODERMAP_LAYERS_RAW ((uint8_t)(sizeof(encoder_map) / ((NUM_ENCODERS) * (NUM_DIRECTIONS) * sizeof(uint16_t))))
      |                                                        ^
quantum/keymap_introspection.c:62:21: note: in expansion of macro 'NUM_ENCODERMAP_LAYERS_RAW'
   62 |     if (layer_num < NUM_ENCODERMAP_LAYERS_RAW && encoder_idx < NUM_ENCODERS) {
      |                     ^~~~~~~~~~~~~~~~~~~~~~~~~
quantum/keymap_introspection.c: In function 'encodermap_layer_count_raw':
quantum/keymap_introspection.c:53:1: error: control reaches end of non-void function [-Werror=return-type]
   53 | }
      | ^
cc1: all warnings being treated as errors
 [ERRORS]
 |
 |
 |
make[1]: *** [builddefs/common_rules.mk:373: .build/obj_keychron_q10_pro_ansi_encoder_arsenik/quantum/keymap_introspection.o] Error 1
Make finished with errors
make: *** [Makefile:416: keychron/q10_pro/ansi_encoder:arsenik] Error 1

Here is my current keyboard: https://github.com/clementpoiret/qmk_firmware/tree/main/keyboards/keychron/q10_pro

Do you know how to fix it?

[Nuclear-Squid]

Woops, I forgot to document this but this error is raised when your keyboard uses a layout that As-QMK doesn’t know. It should be easy to fix, we just need to add the layout for your keyboard at the end of the arsenik.h file. I’ll try to improve the process of reporting / contributing unsupported keyboards.

[Nuclear-Squid]

OK, I just opened a PR to add support for your keyboard. I also added an angle-mod variant for the iso version, as I felt it could be useful. I made sure it would compile, but there could be bugs, so I haven’t merged it yet. If you could verify that it does, that would be pretty cool ^^

Right now, we can’t actually use the rotary encoders, as I haven’t found a way to implement it differently for all keyboards in a good way, so I disabled them for now.

[clementpoiret]

Awesome, sorry for the delay! Sounds good to me 👌