test: add test for overwriting 0-size file when overwrite=False

Author: kan-fu

tests/archive_file/conftest.py

@@ -18,3 +18,9 @@ def params_location():
 def params_location_multiple_pages(params_location):
     # rowLimit should be less than the total number of rows.
     return params_location | {"rowLimit": 2}
+
+
+@pytest.fixture
+def params_location_single_file(params_location):
+    # Returned archivefile name should be BPR-Folger-59_20191126T000000.000Z.txt
+    return params_location | {"dateFrom": "2019-11-26", "dateTo": "2019-11-27"}

tests/archive_file/test_archivefile_direct_download.py

@@ -1,3 +1,6 @@
+import os
+
+
 def test_valid_params_one_page(requester, params_location, util):
     data = requester.getArchivefile(params_location)
     result = requester.downloadDirectArchivefile(params_location)
@@ -16,3 +19,24 @@ def test_valid_params_multiple_pages(requester, params_location_multiple_pages,
     )
 
     assert result["stats"]["fileCount"] == params_location_multiple_pages["rowLimit"]
+
+
+def test_valid_params_overwrite_zero_file_size(
+    requester, params_location_single_file, util
+):
+    filename = "BPR-Folger-59_20191126T000000.000Z.txt"
+
+    file_path = requester.outPath / filename
+
+    # Touch an empty file
+    with open(file_path, "w"):
+        pass
+
+    # Case when downloading failed, leaving an empty file behind
+    assert os.path.getsize(file_path) == 0
+
+    requester.downloadDirectArchivefile(params_location_single_file, overwrite=False)
+
+    assert (
+        os.path.getsize(file_path) != 0
+    ), "0-size file should be overwritten even if overwrite is False"

tests/archive_file/test_archivefile_download.py

@@ -1,3 +1,5 @@
+import os
+
 import pytest
 import requests
 
@@ -25,3 +27,22 @@ def test_valid_params(requester, util):
     requester.downloadArchivefile(filename, overwrite=True)
 
     assert util.get_download_files_num(requester) == 1
+
+
+def test_valid_params_overwrite_zero_file_size(requester):
+    filename = "BPR-Folger-59_20191123T000000.000Z.txt"
+
+    file_path = requester.outPath / filename
+
+    # Touch an empty file
+    with open(file_path, "w"):
+        pass
+
+    # Case when downloading failed, leaving an empty file behind
+    assert os.path.getsize(file_path) == 0
+
+    requester.downloadArchivefile(filename, overwrite=False)
+
+    assert (
+        os.path.getsize(file_path) != 0
+    ), "0-size file should be overwritten even if overwrite is False"