Skip to content

*: fix duties cache #4263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
obol-bulldozer merged 3 commits into from
Jan 29, 2026
Merged

*: fix duties cache #4263

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8ff89d7
Fix erroring on unknown key in proposer duty
KaloyanTanev Jan 29, 2026
2f4e247
Add debug logs on reorgs
KaloyanTanev Jan 29, 2026
3db315b
Fix metric labels
KaloyanTanev Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions app/eth2wrap/cache.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ import (

"github.com/obolnetwork/charon/app/errors"
"github.com/obolnetwork/charon/app/featureset"
"github.com/obolnetwork/charon/app/log"
"github.com/obolnetwork/charon/app/z"
)

// dutiesCacheTrimThreshold is the number of epochs after which duties are trimmed from the cache.
Expand Down Expand Up @@ -281,7 +283,7 @@ func (c *DutiesCache) UpdateCacheIndices(_ context.Context, indices []eth2p0.Val
// InvalidateCache handles chain reorg, invalidating cached duties.
// The epoch parameter indicates at which epoch the reorg led us to.
// Meaning, we should invalidate all duties prior to that epoch.
func (c *DutiesCache) InvalidateCache(_ context.Context, epoch eth2p0.Epoch) {
func (c *DutiesCache) InvalidateCache(ctx context.Context, epoch eth2p0.Epoch) {
c.mu.Lock()
defer c.mu.Unlock()

Expand All @@ -308,7 +310,10 @@ func (c *DutiesCache) InvalidateCache(_ context.Context, epoch eth2p0.Epoch) {
}

if invalidated {
log.Debug(ctx, "Reorg occurred through epoch transition, invalidating duties cache", z.U64("reorged_back_to_epoch", uint64(epoch)))
invalidatedCacheDueReorgCount.WithLabelValues("validators").Inc()
} else {
log.Debug(ctx, "Reorg occurred, but it was not through epoch transition, duties cache is not invalidated", z.U64("reorged_epoch", uint64(epoch)))
}
}

Expand All @@ -326,11 +331,11 @@ func (c *DutiesCache) ProposerDutiesCache(ctx context.Context, epoch eth2p0.Epoc
duties, ok := c.cachedProposerDuties(epoch, vidxs)

if ok {
usedCacheCount.WithLabelValues("validators").Inc()
usedCacheCount.WithLabelValues("proposer_duties").Inc()
return duties, nil
}

missedCacheCount.WithLabelValues("validators").Inc()
missedCacheCount.WithLabelValues("proposer_duties").Inc()
c.mu.Lock()
defer c.mu.Unlock()

Expand Down Expand Up @@ -375,11 +380,11 @@ func (c *DutiesCache) AttesterDutiesCache(ctx context.Context, epoch eth2p0.Epoc
duties, ok := c.cachedAttesterDuties(epoch, vidxs)

if ok {
usedCacheCount.WithLabelValues("validators").Inc()
usedCacheCount.WithLabelValues("attester_duties").Inc()
return duties, nil
}

missedCacheCount.WithLabelValues("validators").Inc()
missedCacheCount.WithLabelValues("attester_duties").Inc()
c.mu.Lock()
defer c.mu.Unlock()

Expand Down Expand Up @@ -412,11 +417,11 @@ func (c *DutiesCache) SyncCommDutiesCache(ctx context.Context, epoch eth2p0.Epoc
duties, ok := c.cachedSyncDuties(epoch, vidxs)

if ok {
usedCacheCount.WithLabelValues("validators").Inc()
usedCacheCount.WithLabelValues("sync_committee_duties").Inc()
return duties, nil
}

missedCacheCount.WithLabelValues("validators").Inc()
missedCacheCount.WithLabelValues("sync_committee_duties").Inc()
c.mu.Lock()
defer c.mu.Unlock()

Expand Down
3 changes: 2 additions & 1 deletion core/validatorapi/validatorapi.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1131,7 +1131,8 @@ func (c Component) ProposerDuties(ctx context.Context, opts *eth2api.ProposerDut

pubshare, ok := c.getPubShareFunc(duty.PubKey)
if !ok {
return nil, errors.New("pubshare not found")
// Ignore unknown validators since ProposerDuties returns ALL proposers for the epoch if validatorIndices is empty.
continue
}

duty.PubKey = pubshare
Expand Down
Loading