Skip to content

vulnerability checks too strict #401

@benhayes21

Description

@benhayes21

vulnerabilitytobin includes the validate vulnerability function to ensure that converted files follow the recommended file structure, but these include recommendations that are not required for the file.

The result is that "valid" files can fail on conversion, but because the process checks and writes at the same time, we see partial converted binary files. If the failure message is not seen by the user (or the process is automated), we end up with partial vulnerability.bin files.

Recommendation is that we relax/update the validation checks to ensure only those that are required for gulcalc/gulpy/gulmc to complete successfully.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

Status

Todo

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions