Please improve your exception handling

[udf2457]

At the moment, your code appears to make no attempt whatsoever to catch errors... after entering database details on the first install.php screen and clicking submit, I was greeted by a white screen.

No on-screen error messages, only found out more once I'd dug through the PHP logs.

PHP message: PHP Warning: chmod(): Operation not permitted in /usr/XXXX/www/lib/PhpRbac/install
.php on line 286
PHP message: PHP Fatal error: Uncaught exception 'PDOException' with message 'SQLSTATE[HY000] [14] unable to
open database file' in /usr/XXXX/www/lib/PhpRbac/src/PhpRbac/core/setup.php:51

[abiusx]

You apparently don’t have PHP error reporting enabled. PHP RBAC is a library, not an application. A library is not allowed to generate output on its own.

---

Notice: This message is digitally signed, its source and integrity are verifiable.
If you mail client does not support S/MIME verification, it will display a file (smime.p7s), which includes the X.509 certificate and the signature body. Read more at Certified E-Mail with Comodo and Thunderbird in AbiusX.com

On Mar 15, 2014, at 6:04 AM, udf2457 notifications@github.com wrote:

At the moment, your code appears to make no attempt whatsoever to catch errors... after entering database details on the first install.php screen and clicking submit, I was greeted by a white screen.

No on-screen error messages, only found out more once I'd dug through the PHP logs.

PHP message: PHP Warning: chmod(): Operation not permitted in /usr/XXXX/www/lib/PhpRbac/install
.php on line 286
PHP message: PHP Fatal error: Uncaught exception 'PDOException' with message 'SQLSTATE[HY000] [14] unable to
open database file' in /usr/XXXX/www/lib/PhpRbac/src/PhpRbac/core/setup.php:51

—
Reply to this email directly or view it on GitHub.

[udf2457]

Actually I disagree. If you are specifically creating an install.php file which is user-interactive, you should cope with errors properly as part of that interaction !

[abiusx]

ok then we shall do in the next release :D

---

Notice: This message is digitally signed, its source and integrity are verifiable.
If you mail client does not support S/MIME verification, it will display a file (smime.p7s), which includes the X.509 certificate and the signature body. Read more at Certified E-Mail with Comodo and Thunderbird in AbiusX.com

On Mar 15, 2014, at 2:00 PM, udf2457 notifications@github.com wrote:

Actually I disagree. If you are specifically creating an install.php file which is user-interactive, you should cope with errors properly as part of that interaction !

—
Reply to this email directly or view it on GitHub.

[jburns131]

I'll be sure to work on that, thanks for the feedback :-)

[udf2457]

Well, you know, someone has to keep an eye on you crazy coders. ;-)

[jburns131]

;-)

[jburns131]

@udf2457: Can you please put this line of code on the top of the 'install.php' file:

<?php error_reporting(-1); ?>

This will turn error reporting up to it's highest level. Please report the errors you are receiving.

Thank you.