-
Notifications
You must be signed in to change notification settings - Fork 1
Open
Description
Here I would make 2 major changes:
- combine
find_best_fp_powers()andfp_model()into one single functionfp_model()the behavior of which depends on the arguments values that are given (either specific values for estimating a specific model or a range of values to look for (and estimate) the best model over that range). The rational is that we want the user experience as seamless as possible. - I don't think we want to feed the function with a sequence
pof powers to brute-force try in turn. Instead, we want to find the best power value in a range using an optimization algorithm as implemented in theoptim()function (unless you manage to convince me of a particular application case where exhaustively looking at predefined values of power could be useful).
Metadata
Metadata
Assignees
Labels
No labels