From 8650e893238aa5047a53b587366b7d8096bad8be Mon Sep 17 00:00:00 2001 From: olgamaluhacodacy Date: Fri, 25 Nov 2022 12:08:01 +0100 Subject: [PATCH 01/10] some minor changes --- src/main/java/com/codacy/utils/Math.java | 12 +++++++++++- src/main/java/com/codacy/utils/Math2.java | 10 ++-------- 2 files changed, 13 insertions(+), 9 deletions(-) diff --git a/src/main/java/com/codacy/utils/Math.java b/src/main/java/com/codacy/utils/Math.java index d674ac2..412e513 100644 --- a/src/main/java/com/codacy/utils/Math.java +++ b/src/main/java/com/codacy/utils/Math.java @@ -7,12 +7,18 @@ public class Math { public Math(int magicNumber) { this.magicNumber = magicNumber; } - /** * Adds 2 numbers, unless there is a magic number on the second argument */ public int magicAdd(int x, int y) { if (y == magicNumber) { + System.out.println("hey"); + System.out.println("hey"); + System.out.println("hey"); + System.out.println("hey"); + System.out.println("hey"); + System.out.println("hey"); + System.out.println("hey"); System.out.println("hey"); System.out.println("hey"); System.out.println("hey"); @@ -27,6 +33,10 @@ public int magicAdd(int x, int y) { System.out.println("hey"); System.out.println("hey"); System.out.println("hey"); + System.out.println("hey"); + System.out.println("hey"); + System.out.println("hey"); + System.out.println("hey"); return x + y; } } diff --git a/src/main/java/com/codacy/utils/Math2.java b/src/main/java/com/codacy/utils/Math2.java index 65071e1..d1642b3 100644 --- a/src/main/java/com/codacy/utils/Math2.java +++ b/src/main/java/com/codacy/utils/Math2.java @@ -7,15 +7,13 @@ public class Math2 { public Math2(int magicNumber) { this.magicNumber = magicNumber; } - /** * Adds 2 numbers, unless there is a magic number on the second argument */ public int magicAdd(int x, int y) { if (y == magicNumber) { System.out.println("hey"); - System.out.println("hey"); - System.out.println("hey"); + System.out.println("hey");; System.out.println("hey"); System.out.println("hey"); System.out.println("hey"); @@ -33,11 +31,7 @@ public int magicAdd(int x, int y) { System.out.println("hey"); System.out.println("hey"); System.out.println("hey"); - System.out.println("hey"); - System.out.println("hey"); - System.out.println("hey"); - System.out.println("hey"); - return x + y; + return y + x; } } } From 645fe22d929ea93df0bd49f64c9733cc0baacc4a Mon Sep 17 00:00:00 2001 From: olgamaluhacodacy Date: Wed, 30 Nov 2022 10:47:06 +0100 Subject: [PATCH 02/10] some minor changes 2 --- src/main/java/com/codacy/utils/Math.java | 3 +++ src/main/java/com/codacy/utils/Math2.java | 3 +++ 2 files changed, 6 insertions(+) diff --git a/src/main/java/com/codacy/utils/Math.java b/src/main/java/com/codacy/utils/Math.java index 412e513..b9e51a6 100644 --- a/src/main/java/com/codacy/utils/Math.java +++ b/src/main/java/com/codacy/utils/Math.java @@ -37,6 +37,9 @@ public int magicAdd(int x, int y) { System.out.println("hey"); System.out.println("hey"); System.out.println("hey"); + System.out.println("hey"); + System.out.println("hey"); + System.out.println("hey"); return x + y; } } diff --git a/src/main/java/com/codacy/utils/Math2.java b/src/main/java/com/codacy/utils/Math2.java index d1642b3..2339314 100644 --- a/src/main/java/com/codacy/utils/Math2.java +++ b/src/main/java/com/codacy/utils/Math2.java @@ -31,6 +31,9 @@ public int magicAdd(int x, int y) { System.out.println("hey"); System.out.println("hey"); System.out.println("hey"); + System.out.println("hey"); + System.out.println("hey"); + System.out.println("hey"); return y + x; } } From 39a3b252f55d9e7343da4ae2e7314059f0d9e593 Mon Sep 17 00:00:00 2001 From: olgamaluhacodacy Date: Thu, 29 Dec 2022 16:31:34 +0100 Subject: [PATCH 03/10] some minor changes 3 --- src/main/java/com/codacy/utils/Math.java | 1 + 1 file changed, 1 insertion(+) diff --git a/src/main/java/com/codacy/utils/Math.java b/src/main/java/com/codacy/utils/Math.java index b9e51a6..286d112 100644 --- a/src/main/java/com/codacy/utils/Math.java +++ b/src/main/java/com/codacy/utils/Math.java @@ -3,6 +3,7 @@ public class Math { private int magicNumber; + int some = 1; public Math(int magicNumber) { this.magicNumber = magicNumber; From e5be00ca984b0c3f8f2057428346d1487b073fc0 Mon Sep 17 00:00:00 2001 From: olgamaluhacodacy Date: Thu, 29 Dec 2022 16:37:55 +0100 Subject: [PATCH 04/10] some minor changes 4 --- src/main/java/com/codacy/utils/Math.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/com/codacy/utils/Math.java b/src/main/java/com/codacy/utils/Math.java index 286d112..3dd028f 100644 --- a/src/main/java/com/codacy/utils/Math.java +++ b/src/main/java/com/codacy/utils/Math.java @@ -41,7 +41,7 @@ public int magicAdd(int x, int y) { System.out.println("hey"); System.out.println("hey"); System.out.println("hey"); - return x + y; + return x + y + some; } } } From d4775a9d31fc15df428151a6927c41937f506dd8 Mon Sep 17 00:00:00 2001 From: olgamaluhacodacy Date: Thu, 29 Dec 2022 16:47:34 +0100 Subject: [PATCH 05/10] some minor changes 4 --- src/main/java/com/codacy/utils/Math2.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/com/codacy/utils/Math2.java b/src/main/java/com/codacy/utils/Math2.java index 2339314..b8fb850 100644 --- a/src/main/java/com/codacy/utils/Math2.java +++ b/src/main/java/com/codacy/utils/Math2.java @@ -13,7 +13,7 @@ public Math2(int magicNumber) { public int magicAdd(int x, int y) { if (y == magicNumber) { System.out.println("hey"); - System.out.println("hey");; + System.out.println("hey");;::: System.out.println("hey"); System.out.println("hey"); System.out.println("hey"); From 3be913be60eab88767f447e4550ec82a9bcfe863 Mon Sep 17 00:00:00 2001 From: olgamaluhacodacy Date: Thu, 29 Dec 2022 16:53:22 +0100 Subject: [PATCH 06/10] some minor changes 5 --- src/main/java/com/codacy/utils/Math.java | 2 +- src/main/java/com/codacy/utils/Math2.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/main/java/com/codacy/utils/Math.java b/src/main/java/com/codacy/utils/Math.java index 3dd028f..286d112 100644 --- a/src/main/java/com/codacy/utils/Math.java +++ b/src/main/java/com/codacy/utils/Math.java @@ -41,7 +41,7 @@ public int magicAdd(int x, int y) { System.out.println("hey"); System.out.println("hey"); System.out.println("hey"); - return x + y + some; + return x + y; } } } diff --git a/src/main/java/com/codacy/utils/Math2.java b/src/main/java/com/codacy/utils/Math2.java index b8fb850..587251d 100644 --- a/src/main/java/com/codacy/utils/Math2.java +++ b/src/main/java/com/codacy/utils/Math2.java @@ -13,7 +13,7 @@ public Math2(int magicNumber) { public int magicAdd(int x, int y) { if (y == magicNumber) { System.out.println("hey"); - System.out.println("hey");;::: + System.out.println("hey"); System.out.println("hey"); System.out.println("hey"); System.out.println("hey"); From faee7fed10624f209e20beb7b8ec587349db35e5 Mon Sep 17 00:00:00 2001 From: olgamaluhacodacy Date: Thu, 29 Dec 2022 17:02:38 +0100 Subject: [PATCH 07/10] some minor changes 6 --- src/main/java/com/codacy/utils/Math.java | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/main/java/com/codacy/utils/Math.java b/src/main/java/com/codacy/utils/Math.java index 286d112..44f9539 100644 --- a/src/main/java/com/codacy/utils/Math.java +++ b/src/main/java/com/codacy/utils/Math.java @@ -5,9 +5,8 @@ public class Math { private int magicNumber; int some = 1; - public Math(int magicNumber) { - this.magicNumber = magicNumber; - } + public Math(int magicNumber) this.magicNumber =magicNumber; +} /** * Adds 2 numbers, unless there is a magic number on the second argument */ From 7b21290bf15e021ce051aecf1cfca842bceb520b Mon Sep 17 00:00:00 2001 From: olgamaluhacodacy Date: Thu, 29 Dec 2022 17:38:03 +0100 Subject: [PATCH 08/10] some minor changes 7 --- src/main/java/com/codacy/utils/Math.java | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/main/java/com/codacy/utils/Math.java b/src/main/java/com/codacy/utils/Math.java index 44f9539..baf5c90 100644 --- a/src/main/java/com/codacy/utils/Math.java +++ b/src/main/java/com/codacy/utils/Math.java @@ -1,12 +1,15 @@ package com.codacy.utils; +package com.codacy.utils; +package com.codacy.utils; public class Math { private int magicNumber; int some = 1; - public Math(int magicNumber) this.magicNumber =magicNumber; -} + public Math(int magicNumber) { + this.magicNumber = magicNumber; + } /** * Adds 2 numbers, unless there is a magic number on the second argument */ From d72a1a271e6318b5c66f1132a75ca59c1804d490 Mon Sep 17 00:00:00 2001 From: olgamaluhacodacy Date: Thu, 29 Dec 2022 17:43:09 +0100 Subject: [PATCH 09/10] some minor changes 8 --- src/main/java/com/codacy/utils/Math.java | 2 -- src/main/java/com/codacy/utils/Math2.java | 2 +- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/src/main/java/com/codacy/utils/Math.java b/src/main/java/com/codacy/utils/Math.java index baf5c90..286d112 100644 --- a/src/main/java/com/codacy/utils/Math.java +++ b/src/main/java/com/codacy/utils/Math.java @@ -1,6 +1,4 @@ package com.codacy.utils; -package com.codacy.utils; -package com.codacy.utils; public class Math { diff --git a/src/main/java/com/codacy/utils/Math2.java b/src/main/java/com/codacy/utils/Math2.java index 587251d..6b49bf7 100644 --- a/src/main/java/com/codacy/utils/Math2.java +++ b/src/main/java/com/codacy/utils/Math2.java @@ -15,7 +15,7 @@ public int magicAdd(int x, int y) { System.out.println("hey"); System.out.println("hey"); System.out.println("hey"); - System.out.println("hey"); + System.out.println("hey");;;; System.out.println("hey"); return y - x; } else { From 3e8fcdd4a42271232c71f05a2ba4d0f31bec6d79 Mon Sep 17 00:00:00 2001 From: olgamaluhacodacy Date: Fri, 30 Dec 2022 16:19:55 +0100 Subject: [PATCH 10/10] some minor changes 9 --- src/test/java/com/codacy/utils/Math2Test.java | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/test/java/com/codacy/utils/Math2Test.java b/src/test/java/com/codacy/utils/Math2Test.java index c34b8ba..65f2d26 100644 --- a/src/test/java/com/codacy/utils/Math2Test.java +++ b/src/test/java/com/codacy/utils/Math2Test.java @@ -13,9 +13,9 @@ public void shouldAddNumbers() { } // Uncomment this to have 100% coverage - @Test - public void shouldSubtractIfMagicNumber() { - Math2 math = new Math2(4); - assertEquals(1, math.magicAdd(3, 4)); - } +// @Test +// public void shouldSubtractIfMagicNumber() { +// Math2 math = new Math2(4); +// assertEquals(1, math.magicAdd(3, 4)); +// } }