Additional language support

[itpropro]

🏷️ Feature Type

New languages

🔖 Feature description

I saw that there are some changes going on currently with the lsp integration.
I wanted to add vue support (volar and ts_ls wit the vue plugin) in my own config and then contribute it here.
What would be the best way to go here currently? vim.lsp.enable?

[NotAShelf]

For personal use, vim.lsp is perfectly suitable. It's designed to leverage the new API in 0.11 to configure the LSP with Nix easily. If you are interested in also contributing the new LSP back as a langage module, then you're welcome to open a PR and add it to nvf :)

[itpropro]

I am still fighting with getting it to work, but I saw that the built-in languages didn't use the vim.lsp syntax. I just wanted to ask so I don't have to change a lot when contributing back.
Currently I am just having a hard time getting custom lsps to attach, but I probably just have to try around until I have some config that works.

[yashranjan1]

hey, have you been able to find a solution for this? ive been struggling as well...

[itpropro]

hey, have you been able to find a solution for this? ive been struggling as well...

Yes, I have implemented everything that I needed for vue with nvf. Adding new lsps from lspconfig is pretty easy actually:

lsp = {
  lspconfig = {
    enable = true;
    sources = {
      vue_ls = ''
        vim.lsp.enable('vue_ls')
        vim.lsp.config('vue_ls', {})
      '';
      eslint = ''
        vim.lsp.enable('eslint')
        vim.lsp.config('eslint', {})
      '';
      ts_ls = ''
        vim.lsp.enable('ts_ls')
        vim.lsp.config('ts_ls', {
          init_options = {
            plugins = {
              {
                name = "@vue/typescript-plugin",
                location = "${pkgs.vue-language-server}/lib/node_modules/@vue/language-server",
                languages = {"vue"},
              },
            },
          },
          filetypes = {
            "javascript",
            "typescript",
            "vue",
          },
        })
      '';
    };
  };
};

This is my config with eslint. I am not using prettier, but using eslint as formatter as well, so I also disabled prettier in the conform-nvim formatter config in nvf.

I am using home manager, so I also added these 3 language servers to the home.packages part of my nvf module:

typescript-language-server
vscode-langservers-extracted
vue-language-server

[yashranjan1]

Thank you so much!

[horriblename]

with the new vim.lsp.servers api the following is recommended

vim.lsp.servers = {
  yamlls = {
    cmd = [(lib.getExe pkgs.yaml-language-server) "--stdio"];
    settings = {...} ;
  };
} 

see options docs for details on vim.lsp.servers

[itpropro]

with the new vim.lsp.servers api the following is recommended

vim.lsp.servers = {
  yamlls = {
    cmd = [(lib.getExe pkgs.yaml-language-server) "--stdio"];
    settings = {...} ;
  };
} 

see options docs for details on vim.lsp.servers

Is this only referring to the home.packages part?

[horriblename]

I'm not really sure what you're talking about with home.packages

lsp = {
  lspconfig = {
    enable = true;
    sources = {
      vue_ls = ''
        vim.lsp.enable('vue_ls')
        vim.lsp.config('vue_ls', {})
      '';
      ...
    };
  };
};

i was referring to this part. vim.lsp.servers maps one to one with the lua vim.lsp.config API (with the addition of an enable option). So you don't have to write the lua code by hand.

this is the updated code:

vim.lsp.servers = {
  vue_ls = {};
};

vim.lsp.lspconfig.sources is the old way of configuring via lspconfig and we'll probably remove/deprecate at some point in the future