Both deno_ls and ts_ls are attached to Node project

[kakapt]

I have confirmed that this is a bug related to nvf

• This is a bug, and not an user error or a support request. I understand that my issue will be closed if it is not a bug in nvf.
• I have checked the issues tab and confirmed that my issue has not yet been reported. I understand that my issue will be closed if it is a duplicate.

Description

With this config snippet:

          ts = {
            enable = true;
            # extraDiagnostics.enable = true;
            format.enable = true;
            lsp = {
              enable = true;
              servers = [
                "ts_ls"
                "denols"
              ];
            };
            treesitter.enable = true;
          };

I got both deno_ls and ts_ls enabled on a Node project. Running :checkhealth vim.lsp, I got the following debug:

vim.lsp: Active Clients ~
- denols (id: 1)
  - Version: 2.6.5 (release, x86_64-unknown-linux-gnu)
  - Root directory: ~/code/javascript/ts_ls_test
  - Command: { "/nix/store/xssqfprccv3d3yyq8kv7phc5pkm1p3kg-deno-2.6.5/bin/deno", "lsp" }
  - Settings: {
      deno = {
        enable = true,
        suggest = {
          imports = {
            hosts = {
              ["https://deno.land"] = true
            }
          }
        }
      }
    }
  - Attached buffers: 1
- ts_ls (id: 2)
  - Version: ? (no serverInfo.version response)
  - Root directory: ~/code/javascript/ts_ls_test
  - Command: { "/nix/store/6jvszlw63qwh2fzgn5ajkila00wqq028-typescript-language-server-5.1.3/bin/typescript-language-server", "--stdio" }
  - Settings: {}
  - Attached buffers: 1

Installation Method

Home manager Module (homeManagerModules.default)

nvf Version

master

Reproduction steps

1. Create a Nodejs with npm init -y
2. Create a tsconfig.json file
3. Got both lsp server enabled

Expected behavior

Only ts_ls should be enabled

Actual Behavior

Both ts_ls and deno_ls are enabled

System Information

- system: `"x86_64-linux"`
- host os: `Linux 6.18.7, NixOS, 26.05 (Yarara), 26.05.20260126.bfc1b8a`
- multi-user?: `yes`
- sandbox: `yes`
- version: `nix-env (Nix) 2.31.3`
- nixpkgs: `/nix/store/12azrzlywd7jmsg1q9n4dpqqgb33p2wl-source`

Relevant log output

vim.lsp: Active Clients ~
- denols (id: 1)
  - Version: 2.6.5 (release, x86_64-unknown-linux-gnu)
  - Root directory: ~/code/javascript/ts_ls_test
  - Command: { "/nix/store/xssqfprccv3d3yyq8kv7phc5pkm1p3kg-deno-2.6.5/bin/deno", "lsp" }
  - Settings: {
      deno = {
        enable = true,
        suggest = {
          imports = {
            hosts = {
              ["https://deno.land"] = true
            }
          }
        }
      }
    }
  - Attached buffers: 1
- ts_ls (id: 2)
  - Version: ? (no serverInfo.version response)
  - Root directory: ~/code/javascript/ts_ls_test
  - Command: { "/nix/store/6jvszlw63qwh2fzgn5ajkila00wqq028-typescript-language-server-5.1.3/bin/typescript-language-server", "--stdio" }
  - Settings: {}
  - Attached buffers: 1

[sjcobb2022]

probably the root marker for .git triggering. We should match this with nvim-lspconfig: https://github.com/neovim/nvim-lspconfig/blob/master/lsp/denols.lua

[horriblename]

edit: just saw @sjcobb2022's response, yea we should update that

by default denols also attaches in any git repo (root marker .git), you can disable it by

vim.lsp.servers.denols.root_markers = lib.mkForce [
  "deno.json"
  "deno.jsonc"
];

if you need a more advanced detection method you can conditionally attach the lsp by using vim.lsp.servers.*.root_dir, see the dynamic activation example in :h vim.lsp.enable()

[kakapt]

Here is the sugguestion: 3728. Can we consider adding workspace_required?

[NotAShelf]

workspace_required can already be passed as the LSP options are freeform.

[kakapt]

Removing .git from root_markers and adding workspace_required = true; fixes the double attachments for me. Thanks everyone!

[kakapt]

Btw, can we make these the defaults?

[sjcobb2022]

That's the plan