Is nvf overriding inputs in extraSpecialArgs intentional?

[vipulog]

I’ve noticed that when passing my own inputs via extraSpecialArgs, they seem to get overridden. Only nvf’s inputs are available inside modules. Is this shadowing behavior intentional, or is it a bug?

Minimal example:

{
  inputs = {
    nixpkgs.url = "github:NixOS/nixpkgs/nixos-unstable";
    nvf.url = "github:notashelf/nvf";
    hello.url = "github:NixOS/templates?dir=bash-hello";
  };

  outputs = {
    self,
    nixpkgs,
    ...
  } @ inputs: let
    forEachSystem = nixpkgs.lib.genAttrs ["x86_64-linux"];
  in {
    packages = forEachSystem (system: let
      pkgs = inputs.nixpkgs.legacyPackages.${system};

      neovimConfigured = inputs.nvf.lib.neovimConfiguration {
        inherit pkgs;
        extraSpecialArgs = {inherit inputs;};

        modules = [
          ({inputs, ...}: let
            inputsListStr = builtins.concatStringsSep ", " (builtins.attrNames inputs);
            inputsMsg = "Inputs available in nvf module: ${inputsListStr}";
          in
            builtins.trace inputsMsg {
              vim.extraPackages = [
                inputs.hello.packages.${system}.hello
              ];
            })
        ];
      };
    in {
      default = self.packages.${system}.neovim;
      neovimConfigured = neovimConfigured.neovim;
    });
  };
}

Result:

trace: Inputs available in nvf module: flake-compat, flake-parts, flake-utils, mnw, nixpkgs, self, systems
error:
       … while calling the 'derivationStrict' builtin
         at <nix/derivation-internal.nix>:37:12:
           36|
           37|   strict = derivationStrict drvAttrs;
             |            ^
           38|

       … while evaluating derivation 'nvf-with-helpers'
         whose name attribute is located at /nix/store/8797hshpb8qqgfqnyqm8af2rd17lhrva-source/pkgs/stdenv/generic/make-derivation.nix:482:13

       … while evaluating attribute 'paths' of derivation 'nvf-with-helpers'
         at /nix/store/8797hshpb8qqgfqnyqm8af2rd17lhrva-source/pkgs/build-support/trivial-builders/default.nix:619:11:
          618|           inherit preferLocalBuild allowSubstitutes;
          619|           paths = mapPaths (path: "${path}${stripPrefix}") paths;
             |           ^
          620|           passAsFile = [ "paths" ];

       … while evaluating the option `extraBinPath':

       … while evaluating definitions from `<unknown-file>':

       … while evaluating the option `vim.extraPackages':

       … while evaluating definitions from `<unknown-file>':

       (stack trace truncated; use '--show-trace' to show the full, detailed trace)

       error: attribute 'hello' missing
       at /nix/store/ai396nijr6x0zkq5zqszim9fj2jbsgqf-source/flake.nix:29:17:
           28|               vim.extraPackages = [
           29|                 inputs.hello.packages.${system}.hello
             |                 ^
           30|               ];

[rice-cracker-dev]

yeah it is

nvf/modules/default.nix

Line 25 in eaad512

extraSpecialArgs

[vipulog]

Based on this, I assume you mean this is a bug?

[rice-cracker-dev]

no this is intentional behavior, raf asked me to bump this discussion