Skip to content

CONTRIBUTING.md

Latest commit

 

History

History
142 lines (93 loc) · 4.34 KB

CONTRIBUTING.md

File metadata and controls

142 lines (93 loc) · 4.34 KB

Contributing to dani

Contributions are welcome, and they are greatly appreciated! Every little bit helps, and credit will always be given.

You can contribute in many ways:

Types of Contributions

Report Bugs

Report bugs at https://github.com/vkehfdl1/dani/issues

If you are reporting a bug, please include:

  • Your operating system name and version.
  • Any details about your local setup that might be helpful in troubleshooting.
  • Detailed steps to reproduce the bug.

Fix Bugs

Look through the GitHub issues for bugs. Anything tagged with "bug" and "help wanted" is open to whoever wants to implement a fix for it.

Implement Features

Look through the GitHub issues for features. Anything tagged with "enhancement" and "help wanted" is open to whoever wants to implement it.

Write Documentation

dani could always use more documentation, whether as part of the official docs, in docstrings, or even on the web in blog posts, articles, and such.

Submit Feedback

The best way to send feedback is to file an issue at https://github.com/vkehfdl1/dani/issues.

If you are proposing a new feature:

  • Explain in detail how it would work.
  • Keep the scope as narrow as possible, to make it easier to implement.
  • Remember that this is a volunteer-driven project, and that contributions are welcome :)

Get Started!

Ready to contribute? Here's how to set up dani for local development. Please note this documentation assumes you already have uv and Git installed and ready to go.

  1. Fork the dani repo on GitHub.

  2. Clone your fork locally:

cd <directory_in_which_repo_should_be_created>
git clone git@github.com:YOUR_NAME/dani.git
  1. Now we need to install the environment. Navigate into the directory
cd dani

Then, install and activate the environment with:

uv sync
  1. Install pre-commit to run linters/formatters at commit time:
uv run pre-commit install
  1. Create a branch for local development:
git checkout -b name-of-your-bugfix-or-feature

Now you can make your changes locally.

  1. Don't forget to add test cases for your added functionality to the tests directory.

  2. When you're done making changes, check that your changes pass the formatting tests.

make check

Now, validate that all unit tests are passing:

make test
  1. Before raising a pull request you should also run tox. This will run the tests across different versions of Python:
tox

This requires you to have multiple versions of python installed. This step is also triggered in the CI/CD pipeline, so you could also choose to skip this step locally.

  1. Commit your changes and push your branch to GitHub:
git add .
git commit -m "Your detailed description of your changes."
git push origin name-of-your-bugfix-or-feature
  1. Submit a pull request through the GitHub website.

Pull Request Guidelines

Before you submit a pull request, check that it meets these guidelines:

  1. The pull request should include tests.

  2. If the pull request adds functionality, the docs should be updated. Put your new functionality into a function with a docstring, and add the feature to the list in README.md.

External contribution PR review process

For PRs opened by external contributors, dani follows a lighter event-driven review loop:

  1. A maintainer review runs when the PR is opened.
  2. If changes are requested, the contributor owns the follow-up implementation.
  3. dani reviews again only when the PR changes meaningfully, such as:
    • a new commit (synchronize)
    • a renewed review request
    • another PR-open style re-entry event (reopened, ready_for_review)
    • duplicate webhook deliveries are ignored, using the GitHub delivery id when available and a PR activity fallback key otherwise
    • once all remaining automated review passes are already queued or running, extra PR-activity events are coalesced until one of those passes finishes
  4. The merge bar stays the same as the existing verdict session: requirements must be met, real verification must pass, and the PR must be approveable.
  5. Only completed automated review passes count toward escalation, but queued/running passes still reserve the remaining review budget.
  6. If automated review reaches 10 completed passes without approval, dani immediately escalates the PR to a human maintainer for a manual decision.