nitrokey::get_library_version() is empty when building from detatched source tarballs

[anthraxx]

Hi,

I'm trying to officially package the nitrokey lib/app and currently encountering an issue while running the test as nitrokey::get_library_version() returns an empty string. This may be related to #119 a bit.

It happens when using the detatched source tarballs on the github release page that include signatures (which is awesome btw, thx).

can we get this fixed somehow?

Edit:

Looks like its related to 35ba226

major and minor version for the generated files are properly populated and get_library_vorersion seems to only be used for git version? So ignoring that REQUIRE seems to be acceptable for now?

[szszszsz]

Hi!
Thank you for reporting this. I will add a git version info file on export, which could be later processed. For now it is perfectly fine to work with unknown version result, since this is only additional information with the exact commit sha. Client applications should use get_major_library_version and get_minor_library_version to get the library version.

To sum up, please ignore this test result for now (test: "Test version getter", unittest/test_offline.cc:183). Will be fixed in the next release.