-
Notifications
You must be signed in to change notification settings - Fork 0
Open
Labels
bugSomething isn't workingSomething isn't working
Description
Context
From QA review of issue-37-cli-add-bundle-update-awareness branch.
Problem
In packages/cli/src/commands/packages/run.ts, the child.on("exit", async (code) => { ... }) handler awaits the update check promise before calling process.exit(). If the await Promise.race rejects unexpectedly, process.exit never fires and the process hangs. The 3-second timeout mitigates this, but a try/catch would be defensive.
Suggested Fix
child.on("exit", async (code) => {
if (updateCheckPromise) {
try {
await Promise.race([updateCheckPromise, new Promise((r) => setTimeout(r, 3000))]);
} catch {}
}
process.exit(code ?? 0);
});Severity
Warning — low probability but easy fix.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working