From 22a2e69b4250c1a6617b45f0e64b8adbfde2bd2c Mon Sep 17 00:00:00 2001 From: Eric B Date: Wed, 29 May 2019 09:00:11 -0400 Subject: [PATCH 1/3] Fix crash when getting re-invite while in bye state --- src/nksip_call_uas_dialog.erl | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/nksip_call_uas_dialog.erl b/src/nksip_call_uas_dialog.erl index 8a267d5c..cb7385c4 100644 --- a/src/nksip_call_uas_dialog.erl +++ b/src/nksip_call_uas_dialog.erl @@ -110,7 +110,9 @@ do_request('INVITE', _Req, #dialog{invite=#invite{status=Status}}, _Call) -> proceeding_uas -> {error, retry()}; accepted_uas -> - {error, retry()} + {error, retry()}; + bye -> + {error, no_transaction} end; do_request('BYE', _Req, #dialog{invite=#invite{}=Invite}=Dialog, Call) -> From 1d66f6fe6c534a1c080567ca01c0f974c984bf02 Mon Sep 17 00:00:00 2001 From: Eric B Date: Wed, 29 May 2019 09:10:41 -0400 Subject: [PATCH 2/3] Fix wrong spec for nksip:config() type --- src/nksip.erl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/nksip.erl b/src/nksip.erl index f087925e..dbf0171c 100644 --- a/src/nksip.erl +++ b/src/nksip.erl @@ -60,7 +60,7 @@ #{ plugins => [atom()], sip_listen => binary(), - sip_allow => binary(), + sip_allow => [binary()|string()], sip_supported => binary(), sip_timer_t1 => integer(), sip_timer_t2 => integer(), From 34c42cea53594a1be822655c0dd837713d22b858 Mon Sep 17 00:00:00 2001 From: Eric B Date: Wed, 29 May 2019 09:15:17 -0400 Subject: [PATCH 3/3] fix nksip:config type declaration for sip_listen and sip_supported --- src/nksip.erl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/nksip.erl b/src/nksip.erl index dbf0171c..359c416e 100644 --- a/src/nksip.erl +++ b/src/nksip.erl @@ -59,9 +59,9 @@ -type config() :: #{ plugins => [atom()], - sip_listen => binary(), + sip_listen => binary()|string(), sip_allow => [binary()|string()], - sip_supported => binary(), + sip_supported => [binary()|string()], sip_timer_t1 => integer(), sip_timer_t2 => integer(), sip_timer_t4 => integer(),