From 73b2ac7eeb6828c892c5fe3e475be8bf1be5d809 Mon Sep 17 00:00:00 2001 From: Gautam Date: Wed, 1 Nov 2023 09:06:35 +0530 Subject: [PATCH] Combined TF_RET_CHECK condition and initialised compile_time_const_arg_indices to avoid redundant initialisation Combined the TF_RET_CHECK conditions using && for conciseness. Initialized compile_time_const_arg_indices with false values to avoid redundant initialization in the loop. --- tensorflow/compiler/tf2xla/const_analysis.cc | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/tensorflow/compiler/tf2xla/const_analysis.cc b/tensorflow/compiler/tf2xla/const_analysis.cc index 48513a43fb3..fe68402aca6 100644 --- a/tensorflow/compiler/tf2xla/const_analysis.cc +++ b/tensorflow/compiler/tf2xla/const_analysis.cc @@ -61,13 +61,15 @@ Status GetFunctionBodies(FunctionLibraryRuntime* flib_runtime, Status CondConstInputIndices( absl::Span branch_bodies, - std::vector* const_input_idxs, FunctionLibraryRuntime* flib_runtime) { - TF_RET_CHECK(!branch_bodies.empty()); + TF_RET_CHECK(branch_bodies[0] != nullptr); + std::vector* const_input_idxs, FunctionLibraryRuntime* flib_runtime) { + TF_RET_CHECK(!branch_bodies.empty() && branch_bodies[0] != nullptr); + int num_inputs = branch_bodies[0]->fdef.signature().input_arg_size(); // Stores indices of the "branch function" inputs that are expected to be // compile time constants. - std::vector compile_time_const_arg_indices(num_inputs); + std::vector compile_time_const_arg_indices(num_inputs, false); for (auto fbody : branch_bodies) { TF_RET_CHECK(fbody != nullptr); TF_RETURN_IF_ERROR(BackwardsConstAnalysis(