Adapt the `PineAPFEL` interface

[Radonirinaunimi]

Hi @Radonirinaunimi, I've just downloaded and installed the latest master of pineappl and I was trying to adapt the PineAPFEL interface.
As expected, since the interface changed, when I try to compile the PineAPFEL code I get many errors which, unfortunately, are not very explicative.
Here's what I get:

vb262523@dphnmct139:~/Codes/PineAPFEL/code$ make -j
c++ -std=c++11 -O3 -Wall -Wextra evolve-grid-apfel.cpp -I/usr/local/include -L/usr/local/lib -lLHAPDF -I/usr/local/include/pineappl_capi -L/usr/local/lib -lpineappl_capi -I/usr/local/include -O3 -I/usr/local/include -I/usr/local/include -L/usr/local/lib -lapfelxx -L/usr/local/lib -lLHAPDF -L/usr/local/lib -lyaml-cpp -o evolve-grid-apfel
c++ -std=c++11 -O3 -Wall -Wextra evolve-grid-double-apfel.cpp -I/usr/local/include -L/usr/local/lib -lLHAPDF -I/usr/local/include/pineappl_capi -L/usr/local/lib -lpineappl_capi -I/usr/local/include -O3 -I/usr/local/include -I/usr/local/include -L/usr/local/lib -lapfelxx -L/usr/local/lib -lLHAPDF -L/usr/local/lib -lyaml-cpp -o evolve-grid-double-apfel
evolve-grid-apfel.cpp:171:35: error: use of undeclared identifier 'pineappl_grid_conv_type'; did you mean 'pineappl_grid_conv_types'?
  171 |         pineappl_conv_type conv = pineappl_grid_conv_type(grid, i);
      |                                   ^~~~~~~~~~~~~~~~~~~~~~~
      |                                   pineappl_grid_conv_types
/usr/local/include/pineappl_capi/pineappl_capi.h:1400:6: note: 'pineappl_grid_conv_types' declared here
 1400 | void pineappl_grid_conv_types(const pineappl_grid *grid, pineappl_conv_type *conv_types);
      |      ^
evolve-grid-apfel.cpp:171:65: error: cannot initialize a parameter of type 'pineappl_conv_type *' with an lvalue of type 'std::size_t' (aka 'unsigned long')
  171 |         pineappl_conv_type conv = pineappl_grid_conv_type(grid, i);
      |                                                                 ^
/usr/local/include/pineappl_capi/pineappl_capi.h:1400:78: note: passing argument to parameter 'conv_types' here
 1400 | void pineappl_grid_conv_types(const pineappl_grid *grid, pineappl_conv_type *conv_types);
      |                                                                              ^
evolve-grid-apfel.cpp:180:5: error: no matching function for call to 'pineappl_grid_evolve_info_shape'
  180 |     pineappl_grid_evolve_info_shape(grid, max_orders.data(), evinfo_shape.data());
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/local/include/pineappl_capi/pineappl_capi.h:1473:6: note: candidate function not viable: no known conversion from 'const value_type *' (aka 'const unsigned char *') to 'const bool *' for 2nd argument
 1473 | void pineappl_grid_evolve_info_shape(const pineappl_grid *grid,
      |      ^
 1474 |                                      const bool *order_mask,
      |                                      ~~~~~~~~~~~~~~~~~~~~~~
evolve-grid-apfel.cpp:190:5: error: no matching function for call to 'pineappl_grid_evolve_info'
  190 |     pineappl_grid_evolve_info(grid, max_orders.data(), fac1.data(), frg1.data(), pids_in.data(), x_in.data(), ren1.data());
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~
/usr/local/include/pineappl_capi/pineappl_capi.h:1485:6: note: candidate function not viable: no known conversion from 'const value_type *' (aka 'const unsigned char *') to 'const bool *' for 2nd argument
 1485 | void pineappl_grid_evolve_info(const pineappl_grid *grid,
      |      ^
 1486 |                                const bool *order_mask,
      |                                ~~~~~~~~~~~~~~~~~~~~~~
evolve-grid-apfel.cpp:277:5: error: unknown type name 'pineappl_fktable'
  277 |     pineappl_fktable* fktable = pineappl_grid_evolve(
      |     ^
evolve-grid-apfel.cpp:277:33: error: no matching function for call to 'pineappl_grid_evolve'
  277 |     pineappl_fktable* fktable = pineappl_grid_evolve(
      |                                 ^~~~~~~~~~~~~~~~~~~~
/usr/local/include/pineappl_capi/pineappl_capi.h:1524:16: note: candidate function not viable: requires 14 arguments, but 13 were provided
 1524 | pineappl_grid *pineappl_grid_evolve(const pineappl_grid *grid,
      |                ^                    ~~~~~~~~~~~~~~~~~~~~~~~~~~
 1525 |                                     size_t nb_slices,
      |                                     ~~~~~~~~~~~~~~~~~
 1526 |                                     pineappl_operator_callback slices,
      |                                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 1527 |                                     const pineappl_operator_info *operator_info,
      |                                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 1528 |                                     const int32_t *pids_in,
      |                                     ~~~~~~~~~~~~~~~~~~~~~~~
 1529 |                                     const double *x_in,
      |                                     ~~~~~~~~~~~~~~~~~~~
 1530 |                                     const int32_t *pids_out,
      |                                     ~~~~~~~~~~~~~~~~~~~~~~~~
 1531 |                                     const double *x_out,
      |                                     ~~~~~~~~~~~~~~~~~~~~
 1532 |                                     const size_t *eko_shape,
      |                                     ~~~~~~~~~~~~~~~~~~~~~~~~
 1533 |                                     void *state,
      |                                     ~~~~~~~~~~~~
 1534 |                                     const bool *order_mask,
      |                                     ~~~~~~~~~~~~~~~~~~~~~~~
 1535 |                                     const double *xi,
      |                                     ~~~~~~~~~~~~~~~~~
 1536 |                                     const double *ren1,
      |                                     ~~~~~~~~~~~~~~~~~~~
 1537 |                                     const double *alphas);
      |                                     ~~~~~~~~~~~~~~~~~~~~
evolve-grid-double-apfel.cpp:151:35: error: use of undeclared identifier 'pineappl_grid_conv_type'; did you mean 'pineappl_grid_conv_types'?
  151 |         pineappl_conv_type conv = pineappl_grid_conv_type(grid, i);
      |                                   ^~~~~~~~~~~~~~~~~~~~~~~
      |                                   pineappl_grid_conv_types
/usr/local/include/pineappl_capi/pineappl_capi.h:1400:6: note: 'pineappl_grid_conv_types' declared here
 1400 | void pineappl_grid_conv_types(const pineappl_grid *grid, pineappl_conv_type *conv_types);
      |      ^
evolve-grid-double-apfel.cpp:151:65: error: cannot initialize a parameter of type 'pineappl_conv_type *' with an lvalue of type 'std::size_t' (aka 'unsigned long')
  151 |         pineappl_conv_type conv = pineappl_grid_conv_type(grid, i);
      |                                                                 ^
/usr/local/include/pineappl_capi/pineappl_capi.h:1400:78: note: passing argument to parameter 'conv_types' here
 1400 | void pineappl_grid_conv_types(const pineappl_grid *grid, pineappl_conv_type *conv_types);
      |                                                                              ^
evolve-grid-double-apfel.cpp:160:5: error: no matching function for call to 'pineappl_grid_evolve_info_shape'
  160 |     pineappl_grid_evolve_info_shape(grid, max_orders.data(), evinfo_shape.data());
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/local/include/pineappl_capi/pineappl_capi.h:1473:6: note: candidate function not viable: no known conversion from 'const value_type *' (aka 'const unsigned char *') to 'const bool *' for 2nd argument
 1473 | void pineappl_grid_evolve_info_shape(const pineappl_grid *grid,
      |      ^
 1474 |                                      const bool *order_mask,
      |                                      ~~~~~~~~~~~~~~~~~~~~~~
evolve-grid-double-apfel.cpp:170:5: error: no matching function for call to 'pineappl_grid_evolve_info'
  170 |     pineappl_grid_evolve_info(grid, max_orders.data(), fac1.data(), frg1.data(), pids_in.data(), x_in.data(), ren1.data());
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~
/usr/local/include/pineappl_capi/pineappl_capi.h:1485:6: note: candidate function not viable: no known conversion from 'const value_type *' (aka 'const unsigned char *') to 'const bool *' for 2nd argument
 1485 | void pineappl_grid_evolve_info(const pineappl_grid *grid,
      |      ^
 1486 |                                const bool *order_mask,
      |                                ~~~~~~~~~~~~~~~~~~~~~~
evolve-grid-double-apfel.cpp:259:5: error: unknown type name 'pineappl_fktable'
  259 |     pineappl_fktable* fktable = pineappl_grid_evolve(
      |     ^
evolve-grid-double-apfel.cpp:259:33: error: no matching function for call to 'pineappl_grid_evolve'
  259 |     pineappl_fktable* fktable = pineappl_grid_evolve(
      |                                 ^~~~~~~~~~~~~~~~~~~~
/usr/local/include/pineappl_capi/pineappl_capi.h:1524:16: note: candidate function not viable: requires 14 arguments, but 13 were provided
 1524 | pineappl_grid *pineappl_grid_evolve(const pineappl_grid *grid,
      |                ^                    ~~~~~~~~~~~~~~~~~~~~~~~~~~
 1525 |                                     size_t nb_slices,
      |                                     ~~~~~~~~~~~~~~~~~
 1526 |                                     pineappl_operator_callback slices,
      |                                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 1527 |                                     const pineappl_operator_info *operator_info,
      |                                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 1528 |                                     const int32_t *pids_in,
      |                                     ~~~~~~~~~~~~~~~~~~~~~~~
 1529 |                                     const double *x_in,
      |                                     ~~~~~~~~~~~~~~~~~~~
 1530 |                                     const int32_t *pids_out,
      |                                     ~~~~~~~~~~~~~~~~~~~~~~~~
 1531 |                                     const double *x_out,
      |                                     ~~~~~~~~~~~~~~~~~~~~
 1532 |                                     const size_t *eko_shape,
      |                                     ~~~~~~~~~~~~~~~~~~~~~~~~
 1533 |                                     void *state,
      |                                     ~~~~~~~~~~~~
 1534 |                                     const bool *order_mask,
      |                                     ~~~~~~~~~~~~~~~~~~~~~~~
 1535 |                                     const double *xi,
      |                                     ~~~~~~~~~~~~~~~~~
 1536 |                                     const double *ren1,
      |                                     ~~~~~~~~~~~~~~~~~~~
 1537 |                                     const double *alphas);
      |                                     ~~~~~~~~~~~~~~~~~~~~
6 errors generated.
make: *** [evolve-grid-apfel] Error 1
make: *** Waiting for unfinished jobs....
6 errors generated.
make: *** [evolve-grid-double-apfel] Error 1

Any input from your side is welcome. Thank you!

Originally posted by @vbertone in #344 (comment)

[Radonirinaunimi]

Hi @vbertone, I've pushed the fixes and everything should work now, but I still moved this discussion into an issue just in case.

[vbertone]

Hi @Radonirinaunimi, thank you. I did a couple of tests and indeed everything seems to work fine. Just a minor thing.
When I compile the test code to fill in grids fill-apfelxx-grid.cpp (the one that you put there for me as an example), I get these warnings:

fill-apfelxx-grid.cpp:63:60: warning: suggest braces around initialization of subobject [-Wmissing-braces]
   63 |   pineappl_kinematics scale = { PINEAPPL_KINEMATICS_SCALE, 0 };
      |                                                            ^
      |                                                            {}
fill-apfelxx-grid.cpp:63:60: warning: suggest braces around initialization of subobject [-Wmissing-braces]
   63 |   pineappl_kinematics scale = { PINEAPPL_KINEMATICS_SCALE, 0 };
      |                                                            ^
      |                                                            {}
fill-apfelxx-grid.cpp:66:48: warning: suggest braces around initialization of subobject [-Wmissing-braces]
   66 |       kinematics[i] = { PINEAPPL_KINEMATICS_X, (i - 1) };
      |                                                ^~~~~~~
      |                                                {      }
fill-apfelxx-grid.cpp:66:48: warning: suggest braces around initialization of subobject [-Wmissing-braces]
   66 |       kinematics[i] = { PINEAPPL_KINEMATICS_X, (i - 1) };
      |                                                ^~~~~~~
      |                                                {      }
fill-apfelxx-grid.cpp:84:72: warning: suggest braces around initialization of subobject [-Wmissing-braces]
   84 |   pineappl_scale_func_form scale_mu = {PINEAPPL_SCALE_FUNC_FORM_SCALE, 0};
      |                                                                        ^
      |                                                                        {}
fill-apfelxx-grid.cpp:84:72: warning: suggest braces around initialization of subobject [-Wmissing-braces]
   84 |   pineappl_scale_func_form scale_mu = {PINEAPPL_SCALE_FUNC_FORM_SCALE, 0};
      |                                                                        ^
      |                                                                        {}
6 warnings generated.

Anything to be concerned about?

[Radonirinaunimi]

Hi @vbertone, these are pretty unharmful warnings so you can safely ignore them. But if you want, you can put braces around the union value:

pineappl_kinematics scale = { PINEAPPL_KINEMATICS_SCALE, { 0 } };
// or
pineappl_kinematics scale = { PINEAPPL_KINEMATICS_SCALE, { .scale=0 } }; // work from C++20 (?)

[vbertone]

Hi @Radonirinaunimi, if I really want to get rid of the warnings I need to include two pairs of braces, that is:

  pineappl_kinematics scale = { PINEAPPL_KINEMATICS_SCALE, {{0}} };

I also confirm that:

  pineappl_kinematics scale = { PINEAPPL_KINEMATICS_SCALE, {{.scale=0}} };

works as well.
However, this is just a tiny detail. Thank you.

[Radonirinaunimi]

Hi @vbertone, while trying to play with parallelization with the evolution, I realized that there was a bug that was not caught by the test but only appear in certain scenarios where multiple EKOs are involved. So please use the updated master to get the fix; no changes are required for the interface (as nothing has changed with the signatures).