Skip to content

Investigate Flake8 Pickle Errors #550

@EmilyPascua

Description

@EmilyPascua

Running Flake8 failed during pre-commit hooks due to Pickle related errors for AIT-Core:

ait/core/api.py:62:5: B042 Exception class with `__init__` should pass all args to `super().__init__()` to work in edge cases of `pickle` and `copy.copy()`. It should also not take any kwargs.
ait/core/api.py:86:5: B042 Exception class with `__init__` should pass all args to `super().__init__()` to work in edge cases of `pickle` and `copy.copy()`. It should also not take any kwargs.
ait/core/cmd.py:126:12: E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()`
ait/core/cmd.py:413:52: E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()`
ait/core/dmc.py:88:5: F824 `global TICs` is unused: name is never assigned in scope
ait/core/evr.py:37:52: E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()`
ait/core/limits.py:185:52: E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()`
ait/core/notify.py:51:8: E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()`
ait/core/server/server.py:128:32: E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()`
ait/core/table.py:419:52: E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()`
ait/core/tlm.py:342:12: E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()`
ait/core/tlm.py:345:12: E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()`
ait/core/tlm.py:985:52: E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()`
ait/core/util.py:510:5: B042 Exception class with `__init__` should pass all args to `super().__init__()` to work in edge cases of `pickle` and `copy.copy()`. It should also not take any kwargs.
ait/core/util.py:518:5: B042 Exception class with `__init__` should pass all args to `super().__init__()` to work in edge cases of `pickle` and `copy.copy()`. It should also not take any kwargs.

Perhaps update setup.cfg to ignore these warnings (Need further investigation)

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingbuild

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions