Unable to override config value via `mcconfig` if it contains an equal sign

[eliandoran]

Build environment: Windows
Moddable SDK version: If you are unsure, display it in the terminal using: 7.1.0-2-ge483dc6bf
Target device: Desktop simulator

Description

Steps to Reproduce

1. Define in manifest.json:

  "config": {
    "startUrl": "/"
  },

2. In the app:

import config from "mc/config";
trace("URL: ", config.startUrl);

3. Run mcconfig -d -m -p sim startUrl="/settings?page=foo" (or mcconfig -d -m -p sim --startUrl-=/settings?page=foo)

Notice that the presence of the equals sign in the value results in:

### Error: 'startUrl=/settings?page=foo': manifest not found!

Expected behavior

According to documentation for mcconfig, I can override the config arguments:

config arguments specified in the form of key-=value or key="value". These are merged into the config section of the manifest. Import the mc/config module to access them

So in this case the log should be URL: /settings?page=foo instead of / and there should be no build error.

[phoddie]

Is it possible that you may have misread the documentation? The documented syntax for config values is startURL="/foo", not --startURL="/foo". When you use --startURL, it doesn't match a known mcconfig command line option, so it treats it as a path to a manifest, which explains the "bonus issue" you note.

[eliandoran]

Hi, @phoddie .

I remember trying without the (--) prefix, but then I was misled by the result. Turns out the "bonus issue" is the only issue there is.

To summarize:

• mcconfig -d -m -p sim startUrl=/settings works fine.
• mcconfig -d -m -p sim startUrl=/settings?page=foo fails with manifest not found.
• Tried wrapping in quotes both the entire startUrl argument or the value pair.

I will update the bug description accordingly.

[phoddie]

Both mcconfig and mcrun expressly check for a single equal sign.

moddable/tools/mcmanifest.js

Lines 2450 to 2455 in 5e50973

	default:
	name = argv[argi];
	let split = name.split("=");
	if (split.length == 2) {
	this.config[split[0]] = split[1];
	}

Given the way that command line arguments are provided to the application, quotes are already removed.

The behavior you want can be achieved by changing it to:

				if (split.length >= 2) {
					split.shift();
					this.config[split[0]] = split.join("=");
				}

I hesitate to make a change because it has been like this for some time. I suppose the choice hinges on whether manifest paths with multiple equal signs are common (they probably aren't....).