-
Notifications
You must be signed in to change notification settings - Fork 31
Open
Labels
documentationImprovements or additions to documentationImprovements or additions to documentationenhancementNew feature or requestNew feature or requestquestionFurther information is requestedFurther information is requested
Description
First, thanks again for releasing PPIFlow!
I ran into a few snags when trying to set up the full pipeline end‑to‑end. The repo and environment.yml don’t currently include (or link to) key external dependencies that are referenced throughout the notebook/scripts. Issues I hit:
- Private/undocumented forks used in scripts
- demo_vhh.ipynb and demo_scripts/run_abmpnn.sh point to a private “ProteinMPNN‑qin” and AbMPNN weights.
- flowpacker was referenced with a path on your cluster; it is not bundled or linked in the repo.
- These dependencies are essential to reproduce the notebook’s pipeline.
- environment.yml is incomplete for the full pipeline
- No AF3Score / AlphaFold3 build dependencies.
- No FlowPacker / ProteinMPNN/ AbMPNN requirements.
- The result is that a “clean install” can run core PPIFlow, but not the full pipeline in demo_vhh.ipynb.
- Hard‑coded cluster paths in scripts
- Many scripts point to /lustre/... or your internal environments (e.g., FlowPacker, AF3Score, AbMPNN, Rosetta).
- This makes it very hard for outside users to reproduce.
Suggested fixes:
- Bundle or link all external repos explicitly (FlowPacker, ProteinMPNN/AbMPNN, AF3Score). If private forks are required, provide a public mirror or release tarball.
- Add an install script (or a requirements_pipeline.txt) that installs the full pipeline, not just core PPIFlow.
- Parameterize paths (env vars or CLI args) instead of hard‑coding /lustre/....
- Optional Rosetta: it appears to be an analysis step only: consider marking it optional and off by default.
Ultimately I was able to get most of the pipeline working (though not the AbMPNN link yet). If you can point to a suitable repo/weights that can be used, I would be happy to create this install script.
Thanks again.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
documentationImprovements or additions to documentationImprovements or additions to documentationenhancementNew feature or requestNew feature or requestquestionFurther information is requestedFurther information is requested