From 6a17446d7c8c44541367fd139e074bde73eb9182 Mon Sep 17 00:00:00 2001 From: Mingbo Peng Date: Sun, 14 Sep 2025 00:17:16 -0400 Subject: [PATCH 1/2] refactor(IB_PlantLoop): simplify Equals method implementation - Remove unnecessary commented code - Simplify return statement for base equality check --- src/Ironbug.HVAC/Loops/IB_PlantLoop.cs | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/src/Ironbug.HVAC/Loops/IB_PlantLoop.cs b/src/Ironbug.HVAC/Loops/IB_PlantLoop.cs index 4ea89089..1b9bebe8 100644 --- a/src/Ironbug.HVAC/Loops/IB_PlantLoop.cs +++ b/src/Ironbug.HVAC/Loops/IB_PlantLoop.cs @@ -205,15 +205,8 @@ private bool CheckWithBranch(IEnumerable HvacComponents) public bool Equals(IB_PlantLoop other) { if (!base.Equals(other)) - { - //var otherJ = other?.ToJson(); - //var thisJ = this?.ToJson(); - return false; - //var same = this.Equals(other); - //return false; - } - + if (this.SizingPlant != other.SizingPlant) return false; From 88d135e5c2fc05244691fbc1b17a43c1c3a53870 Mon Sep 17 00:00:00 2001 From: Mingbo Peng Date: Sun, 14 Sep 2025 00:17:22 -0400 Subject: [PATCH 2/2] fix(ci): correct folder name in release workflow - Update folder name from 'ironbug-rhino7' to 'ironbug-net8' in the release workflow - This change ensures consistency between the workflow steps and the correct folder name --- .github/workflows/release.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml index 67f239bd..d9733aea 100644 --- a/.github/workflows/release.yaml +++ b/.github/workflows/release.yaml @@ -82,7 +82,7 @@ jobs: - name: zip plugin - net8 shell: bash run: | - mkdir ./ironbug-rhino7 + mkdir ./ironbug-net8 cp ./installer/plugin-net8/* ./ironbug-net8 -r cp ./installer/HVACTemplates ./ironbug-net8 -r 7z a -tzip ironbug-net8.zip ./ironbug-net8