From 479ab60274b6a27a6f425554a74fc635ba5273ba Mon Sep 17 00:00:00 2001 From: yvdc Date: Fri, 22 Nov 2024 10:32:40 -0500 Subject: [PATCH] comment the redundant run_lasso in fit_itr, as it was overwritting lasso in caret algorithms --- R/main.r | 60 ++++++++++++++++++++++++++++---------------------------- 1 file changed, 30 insertions(+), 30 deletions(-) diff --git a/R/main.r b/R/main.r index c40af4c..bd041cc 100644 --- a/R/main.r +++ b/R/main.r @@ -307,21 +307,21 @@ fit_itr <- function( models[["causal_forest"]] <- est$train } - if("lasso" %in% algorithms){ - # run lasso - est <- run_lasso( - dat_train = training_data_elements, - dat_test = testing_data_elements, - dat_total = total_data_elements, - params = params, - indcv = 1, - iter = 1, - budget = budget - ) - # store the results - fit_ml[["lasso"]] <- est$test - models[["lasso"]] <- est$train - } + # if("lasso" %in% algorithms){ + # # run lasso + # est <- run_lasso( + # dat_train = training_data_elements, + # dat_test = testing_data_elements, + # dat_total = total_data_elements, + # params = params, + # indcv = 1, + # iter = 1, + # budget = budget + # ) + # # store the results + # fit_ml[["lasso"]] <- est$test + # models[["lasso"]] <- est$train + # } if("SuperLearner" %in% algorithms){ # run SuperLearner @@ -586,21 +586,21 @@ fit_itr <- function( models[["causal_forest"]][[j]] <- est$train } - if("lasso" %in% algorithms){ - # run lasso - est <- run_lasso( - dat_train = training_data_elements, - dat_test = testing_data_elements, - dat_total = total_data_elements, - params = params, - indcv = indcv, - iter = j, - budget = budget - ) - # store the results - fit_ml[["lasso"]][[j]] <- est$test - models[["lasso"]][[j]] <- est$train - } + # if("lasso" %in% algorithms){ + # # run lasso + # est <- run_lasso( + # dat_train = training_data_elements, + # dat_test = testing_data_elements, + # dat_total = total_data_elements, + # params = params, + # indcv = indcv, + # iter = j, + # budget = budget + # ) + # # store the results + # fit_ml[["lasso"]][[j]] <- est$test + # models[["lasso"]][[j]] <- est$train + # } if("SuperLearner" %in% algorithms){ # run SuperLearner