-
Notifications
You must be signed in to change notification settings - Fork 12
Get rid of optional compilation flags #346
Description
Optional compilation flags are neat in concept, but in reality are very prone to breakage with the way on how we apply multiple patches at once.
Currently we have the following flags:
- Debug
- Optimize
- QoL
- Accessibility
- Nonlinear
- randomizer
- Bombless PBs
- Missiles without Mains
- Unhidden Map
- Unhidden Map Doors
- Nerf Geron Weaknesses
I'm not quite sure how to handle Debug and Optimize.
QoL can probably be assumed default?
Accessibility might be difficult since we're modifying graphics. Might be possible to just create new enemy types and make room edits that change all the affected enemies? Maybe we can change the respective enemy code to load different graphics instead based on a rom flag?
For nonlinear see #345.
Randomizer has a similar state and should just be assumed default.
Bombless PBs should be easily done with a rom flag
Same goes for Missiles without Mains
Unhidden Map and Unhidden Map Doors I'm not quite sure how to handle either.
Nerf Geron Weaknesses sounds similar to accessibility, but instead of changing enemy graphics we're changing their weaknesses.