-
Notifications
You must be signed in to change notification settings - Fork 639
fix: Remove logic for granting CAIP-25 permissions #3723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3723 +/- ##
==========================================
- Coverage 98.28% 98.27% -0.01%
==========================================
Files 418 418
Lines 12152 12146 -6
Branches 1876 1875 -1
==========================================
- Hits 11943 11937 -6
Misses 209 209 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| messenger, | ||
| state, | ||
| dynamicPermissions = ['eth_accounts'], | ||
| dynamicPermissions = ['endowment:caip25'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to adapt the unit test that used this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
This logic may not be needed. Pending verification.
Note
Removes automatic granting of
endowment:caip25and related network lookups, updates default dynamic permission toendowment:caip25, and adjusts tests accordingly.SnapController.ts):endowment:caip25based onendowment:ethereum-provider(and associated network client lookups); permissions are now granted as requested without modification.NetworkController:getNetworkClientByIdandSelectedNetworkController:getNetworkClientIdForDomainfrom allowed actions; removehex/hexToNumberusage.dynamicPermissionsfrometh_accountstoendowment:caip25.SnapController.test.tsx):endowment:caip25on install/update; keep install/update flows without CAIP-25 injection.endowment:caip25instead ofeth_accounts.Written by Cursor Bugbot for commit 9800313. This will update automatically on new commits. Configure here.