feat: Emit snapInstalled and snapUpdated for preinstalled Snaps
#2900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2900 +/- ##
=======================================
Coverage 94.48% 94.48%
=======================================
Files 486 486
Lines 10399 10405 +6
Branches 1594 1597 +3
=======================================
+ Hits 9825 9831 +6
Misses 574 574 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Mrtenz
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an oversight where preinstalled Snaps would not emit
snapInstalledandsnapUpdated. This would cause lifecycle hooks among other things to not work. This PR also adds apreinstalledflag to the events, this will be necessary to not collect metrics for installation/update of preinstalled Snaps.Additionally, this PR fixes an oversight where preinstalled Snaps could have the manual update flow triggered. For now, we disallow this behaviour.
Progresses #2899