-
Notifications
You must be signed in to change notification settings - Fork 19
Description
Contact Details
Are there any linked Issues or Pull Requests?
Brief description
When pfunit is built with mpi_f08 in our software stack, the unit tests will need to be updated to reflect this.
Further details of the issue.
Currently, within the software stack, pfunit is only built with the legacy version of mpi (i.e. currently there is no mpi_f08 version).
The two versions of mpi are functionally equivalent (it's just that mpi_f08 wraps all integer variables used in the API in objects, to provide type checking).
When most of our parallel unit tests run they will just fall back to using the legacy mpi provided by pfunit - which is fine because (as mentioned above) the two versions of mpi are functionally equivalent.
The only exception is the unit test for mpi_mod. This actually uses some of those integers (that are wrapped in objects in mpi_f08). For expediency, the following workaround was used: the unit test for mpi_mod has been written so the mpi_f08 version falls back to legacy mpi. This is commented in the code when it happens.
When pfunit is available with mpi_f08, the workarounds should be removed.