Skip to content

Ensure correct interpretation of read frequency for files defined in iodef.xml #171

@EdHone

Description

@EdHone

Contact Details

@EdHone

Are there any linked Issues or Pull Requests?

#170 - PR to fix climate run performance pre 3.0

Brief description

After the PR which fixes the egregious performance issues from lfric_core #4576 (SRS) there is no handling for files which have been set up via an iodef.xml files, rather than through the lfric_xios API. This issue will make sure these cases are handled correctly and add integration tests to cover the new functionality.

Further details of the issue.

The code in question is located in lfric_xios_file_mod.f90:

if (.not. self%freq_ts == undef_freq) then
    self%frequency = self%freq_ts * timestep_duration
    call xios_set_attr( self%handle, output_freq=self%frequency )
end if

The case where self%freq_ts is not set needs to be handled correctly, preferably with a call to xios_get_attr to get the correct value, if possible.
Integration tests also need to be added to test these cases.

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions