From ca6c8dfda2d3392724446961eb69f963e505ee0a Mon Sep 17 00:00:00 2001 From: TrellixVulnTeam Date: Sun, 9 Oct 2022 03:09:12 +0000 Subject: [PATCH] Adding tarfile member sanitization to extractall() --- .../dataset/repository/_gp_copula_2019.py | 21 ++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/Code of Winning Methods/A2/gluonts/dataset/repository/_gp_copula_2019.py b/Code of Winning Methods/A2/gluonts/dataset/repository/_gp_copula_2019.py index 2cc2307..62024a3 100644 --- a/Code of Winning Methods/A2/gluonts/dataset/repository/_gp_copula_2019.py +++ b/Code of Winning Methods/A2/gluonts/dataset/repository/_gp_copula_2019.py @@ -118,7 +118,26 @@ def download_dataset(dataset_path: Path, ds_info: GPCopulaDataset): request.urlretrieve(ds_info.url, dataset_path / f"{ds_info.name}.tar.gz") with tarfile.open(dataset_path / f"{ds_info.name}.tar.gz") as tar: - tar.extractall(path=dataset_path) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tar, path=dataset_path) def save_metadata(dataset_path: Path, ds_info: GPCopulaDataset):