Skip to content

Double deaths are not detected #10

@Matsyir

Description

@Matsyir

Related plugin component(s)
A fight's death detection.

Describe the bug
If a double death occurs, only a single death will be detected.

To reproduce
Steps to reproduce the behavior:

  1. Go to clan wars with a friend/alt
  2. Kill each other at the same time
  3. Observe that only the first death is saved.
    Of course, this can also be rarely tested from real fights.

Expected behavior
Both players are marked with a skull to indicate that they died. Perhaps an additional color/tooltip to signify who died first.

Additional context
This can be fixed by subscribing to the onPlayerDeath() event in the main plugin file, and managing deaths from there. It is a bit tricky, since currently fights are immediately ended when either player does the death animation. Some kind of timer/delay must be implemented to wait for a potential second death after the initial one.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workinghas known solutionThere is a known implementation method

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions