Skip to content

Babel 7 version ignoring options? #62

@verydanny

Description

@verydanny

Package.json

    "@babel/cli": "^7.2.3",
    "@babel/core": "^7.2.2",
    "@babel/plugin-proposal-class-properties": "^7.3.0",
    "@babel/plugin-proposal-object-rest-spread": "^7.3.2",
    "@babel/plugin-transform-modules-commonjs": "^7.2.0",
    "@babel/plugin-transform-runtime": "^7.2.0",
    "@babel/preset-env": "^7.3.1",
    "@babel/preset-react": "^7.0.0",
    "@babel/register": "^7.0.0",
    "fast-async": "^7",

My babel.config.js:

module.exports = api => {
  api.cache(true)

  const presets = [
    ['@babel/preset-env', {
      exclude: [
        'transform-async-to-generator',
        'transform-regenerator',
      ],
    }],
    '@babel/preset-react',
  ]

  const plugins = [
    ['module:fast-async', {
      compiler: {
        promises: false,
      },
    }],
    '@babel/plugin-transform-runtime',
    '@babel/plugin-proposal-class-properties',
    '@babel/plugin-proposal-object-rest-spread',
  ]

  const env = {
    commonjs: {
      plugins: [
        ['@babel/plugin-transform-modules-commonjs', { loose: true }],
      ],
    },
  }

  return {
    presets,
    plugins,
    env,
  }
}

Snippet of code:

export default async ({
  store,
  location,
  ...options
}) => {
  if (!store) {
    throw new Error('Expected to receive a redux store.')
  }
  return ({
    dispatch: store.dispatch,
    getState: store.getState,
    location: store.dispatch('hello').location,
    ...options,
  })
}

Out: { compiler: { promises: false }}

"use strict";

var _interopRequireDefault = require("@babel/runtime/helpers/interopRequireDefault");

exports.__esModule = true;
exports.default = void 0;

var _objectSpread2 = _interopRequireDefault(require("@babel/runtime/helpers/objectSpread"));

var _objectWithoutProperties2 = _interopRequireDefault(require("@babel/runtime/helpers/objectWithoutProperties"));

var _default = function _default(_ref) {
  return new Promise(function ($return, $error) {
    var store = _ref.store,
        location = _ref.location,
        options = (0, _objectWithoutProperties2.default)(_ref, ["store", "location"]);

    if (!store) {
      return $error(new Error('Expected to receive a redux store.'));
    }

    return $return((0, _objectSpread2.default)({
      dispatch: store.dispatch,
      getState: store.getState,
      location: store.dispatch('hello').location
    }, options));
  });
};

exports.default = _default;

Out: { compiler: { promises: true }}
Same as above

Is fast-async only spec now? None of the setting seem to impact anything. Does the documentation need to be updated? Thanks

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions