Doesn't account for routes.yaml

[kevnk]

I have several pages that are dynamically built (e.g. pages that list collection items) using site/settings/routes.yaml: https://docs.statamic.com/routing

Here's my routes.yaml for a real-life example:

routes:
  /portal/talks:
    layout: portal
    template: portal/talks
    protect:
      type: logged_in
      login_url: /login
      append_redirect: true
  /latest:
    template: latest
  /login:
    template: login
  /contact:
    template: contact
  /events:
    template: events
  /talks:
    template: talks
  /testimonies:
    template: testimonies
  /blog:
    template: blog
collections:
  /blog/{year}/{month}/{slug}:
    template: default
  /talks/{year}/{month}/{slug}:
    template: default
  /events/{year}/{month}/{slug}:
    template: default
taxonomies: [ ]
redirect: [ ]
vanity: [ ]

The generated /sitemap.xml doesn't contain any of these urls.

[kevnk]

Here's my workaround for now:

SitemapController.php

// ...

use Statamic\API\Config;
use Statamic\Routing\Router;
use Statamic\API\URL;
use Statamic\API\Helper;

class SitemapController extends Controller
{
    // ...

    public function index()
    {
        // ...

        // Add routes from routes.yaml
        $content = $this->_addRoutes($content);

        return response()->make($this->view('index', compact('content')), '200')->header('Content-Type', 'text/xml');
    }

    protected function _addRoutes($content)
    {
        $routes = array_get(Config::getRoutes(), 'routes', []);
        foreach ($routes as $route => $data) {
            $uuid = Helper::makeUuid();
            $content->put($uuid, array(
                'url' => URL::makeAbsolute(URL::prependSiteUrl($route, Config::getDefaultLocale())),
                'date' => null,
                'alternates' => [], // TODO
            ));
        }
        return $content;
    }
}

This workaround only supports the default locale.

[kevnk]

The generated /sitemap.xml doesn't contain any of these urls.

I was wrong. It does support the collections: routes but not routes: routes from routes.yaml. The above workaround adds those routes:.

[riasvdv]

Hi Kevnk,

Would gladly accept a pull request if you're confident this works, we don't really do much development on Statamic currently and don't have the time to improve our plugins beyond what we need.

[kevnk]

Makes sense. I'm in the same kind of scenario here; my workaround above works well enough for me. If I have time to make a legit pull request, I'll see if I can.

Thanks!