From 7685bed852d94ecb27265829e5f9b94a41cf01da Mon Sep 17 00:00:00 2001 From: Jason Frey Date: Tue, 11 Mar 2025 17:33:15 -0400 Subject: [PATCH 1/2] Change truffleruby to go through the regular rake tests Before this commit, they were passing as a false positive, hiding any actual failures. They will now fail as expected. --- Rakefile | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/Rakefile b/Rakefile index 59067f90..10c3076e 100644 --- a/Rakefile +++ b/Rakefile @@ -9,12 +9,19 @@ task default: %i[test rubocop] begin fork { nil } rescue NotImplementedError - # jruby and windows can't fork so use vanilla rake instead + # jruby, truffleruby, and windows can't fork so use vanilla rake instead + warn 'warn: fork is not implemented on this Ruby, falling back to vanilla rake' require 'rake/testtask' + Rake::TestTask.new do |t| + t.libs << 'test' + t.test_files = FileList['test/test_*.rb'] + t.verbose = true + end else desc 'Run each test in isolation' task :test do sh 'forking-test-runner test/test_* --helper test/helper.rb --verbose' end end + RuboCop::RakeTask.new From 271ee08f38240c6b4cd5977cf683dd3edd3e88bb Mon Sep 17 00:00:00 2001 From: Jason Frey Date: Thu, 16 Oct 2025 11:53:10 -0400 Subject: [PATCH 2/2] Allow truffleruby-head to continue-on-error Until we can get to fixing these tests, better to let it pass CI (but still show as failing) as opposed to passing with a false positive. --- .github/workflows/ci.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 1a11f0e9..e5dfa423 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -36,6 +36,7 @@ jobs: bundler-cache: true - name: Run tests run: bin/ci + continue-on-error: ${{ matrix.ruby == 'truffleruby-head' }} lint: runs-on: ubuntu-latest steps: